You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "hamilton-earthscope (via GitHub)" <gi...@apache.org> on 2023/05/18 23:46:03 UTC
[GitHub] [tinkerpop] hamilton-earthscope opened a new pull request, #2071: (fix) (gremlin-python) don't use deprecated methods
hamilton-earthscope opened a new pull request, #2071:
URL: https://github.com/apache/tinkerpop/pull/2071
`gremlin-python` internally calls deprecated methods. This PR fixes that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1555375247
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2071?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2071](https://app.codecov.io/gh/apache/tinkerpop/pull/2071?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6cc55bf) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/f9394a4da0de5e98d5f0ec5817194c16cf236c0b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f9394a4) will **decrease** coverage by `5.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2071 +/- ##
=============================================
- Coverage 69.59% 64.59% -5.00%
=============================================
Files 878 25 -853
Lines 42258 3802 -38456
Branches 5638 0 -5638
=============================================
- Hits 29410 2456 -26954
+ Misses 10869 1179 -9690
+ Partials 1979 167 -1812
```
[see 853 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2071/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1555086935
Thanks for submitting this PR @hamilton-earthscope. I'm always happy to see new users submitting improvements to TinkerPop. It looks like there are many more cases where the deprecated camelCase methods are still being used internally (mostly in the tests). It would be good to get these all updated at some point. Anyways that isn't a blocker for this PR.
Just to give a bit of context as to how our review process works, typically any PR needs 3 VOTE +1's from approved committers to be merged. It can also be merged with a minimum of 1 vote after a week has passed. In your case here, as this is such a small change, a committer may choose to skip the full process and push it in as a CTR (Commit then Review).
I'm not a committer here so the best I can do is give a VOTE +1 (non-binding).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1559948763
Thanks for coming back and fixing the rest of these cases. Don't worry about restarting the approval process, it will be great to have these all fixed. I hope we can get this PR merged soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk merged pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk merged PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] hamilton-earthscope commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "hamilton-earthscope (via GitHub)" <gi...@apache.org>.
hamilton-earthscope commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1555359314
I think I caught the rest of the camelCase usage internally. At least this way users won't get deprecation warnings when they use the lib correctly.
I did not get to the tests.
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1555191370
Thanks for contributing.
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2071: (fix) (gremlin-python) don't use deprecated methods
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2071:
URL: https://github.com/apache/tinkerpop/pull/2071#issuecomment-1563635257
VOTE+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org