You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by GitBox <gi...@apache.org> on 2021/09/15 11:43:52 UTC
[GitHub] [brooklyn-ui] ahgittin opened a new pull request #287: UI awareness of configurable sensitive fields
ahgittin opened a new pull request #287:
URL: https://github.com/apache/brooklyn-ui/pull/287
sensitive fields and whether deployments are blocked are now loaded from the server and set dynamically where used (eg in config values table); and in composer, if plaintext values are blocked a warning appears when the field is being edited
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] asfgit closed pull request #287: UI awareness of configurable sensitive fields
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #287:
URL: https://github.com/apache/brooklyn-ui/pull/287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on pull request #287: UI awareness of configurable sensitive fields
Posted by GitBox <gi...@apache.org>.
ahgittin commented on pull request #287:
URL: https://github.com/apache/brooklyn-ui/pull/287#issuecomment-919947254
depends on https://github.com/apache/brooklyn-server/pull/1258 of course
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] ahgittin commented on a change in pull request #287: UI awareness of configurable sensitive fields
Posted by GitBox <gi...@apache.org>.
ahgittin commented on a change in pull request #287:
URL: https://github.com/apache/brooklyn-ui/pull/287#discussion_r709114574
##########
File path: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
##########
@@ -427,6 +428,31 @@ function BlueprintService($log, $q, $sce, paletteApi, iconGenerator, dslService,
}
function refreshConfigConstraints(entity) {
+ function checkSensitiveFields(config) {
+ console.log("checkConstraints", config);
Review comment:
good spot, fixed, force-pushed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [brooklyn-ui] algairim commented on a change in pull request #287: UI awareness of configurable sensitive fields
Posted by GitBox <gi...@apache.org>.
algairim commented on a change in pull request #287:
URL: https://github.com/apache/brooklyn-ui/pull/287#discussion_r709109810
##########
File path: ui-modules/blueprint-composer/app/components/providers/blueprint-service.provider.js
##########
@@ -427,6 +428,31 @@ function BlueprintService($log, $q, $sce, paletteApi, iconGenerator, dslService,
}
function refreshConfigConstraints(entity) {
+ function checkSensitiveFields(config) {
+ console.log("checkConstraints", config);
Review comment:
Debugging log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org