You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2009/09/11 01:55:57 UTC
[jira] Created: (MAPREDUCE-970)
task-controller/configuration.c:get_values is broken
task-controller/configuration.c:get_values is broken
----------------------------------------------------
Key: MAPREDUCE-970
URL: https://issues.apache.org/jira/browse/MAPREDUCE-970
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: tasktracker
Affects Versions: 0.21.0
Reporter: Arun C Murthy
Assignee: Arun C Murthy
Priority: Blocker
Fix For: 0.21.0
task-controller/configuration.c:get_values is supposed to return a char** with the last element set to NULL.
It doesn't correctly handle empty config-values, #values as an exactly multiple of MAX_SIZE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-970)
task-controller/configuration.c:get_values is broken
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12856529#action_12856529 ]
Tom White commented on MAPREDUCE-970:
-------------------------------------
Arun, this patch has gone stale. Could you regenerate it please?
> task-controller/configuration.c:get_values is broken
> ----------------------------------------------------
>
> Key: MAPREDUCE-970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-970
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-970.patch
>
>
> task-controller/configuration.c:get_values is supposed to return a char** with the last element set to NULL.
> It doesn't correctly handle empty config-values, #values as an exactly multiple of MAX_SIZE.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MAPREDUCE-970)
task-controller/configuration.c:get_values is broken
Posted by "Hemanth Yamijala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859784#action_12859784 ]
Hemanth Yamijala commented on MAPREDUCE-970:
--------------------------------------------
Clearly, the function get_values needs improvement for handling invalid inputs. But it doesn't warrant a blocker status ? Typical usages of this code come from configuration files that are hard to get wrong.
I would definitely love to improve get_values, but there should be no pressure to fix this as a blocker, IMO. Thoughts ?
> task-controller/configuration.c:get_values is broken
> ----------------------------------------------------
>
> Key: MAPREDUCE-970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-970
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-970.patch
>
>
> task-controller/configuration.c:get_values is supposed to return a char** with the last element set to NULL.
> It doesn't correctly handle empty config-values, #values as an exactly multiple of MAX_SIZE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-970)
task-controller/configuration.c:get_values is broken
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-970:
------------------------------------
Priority: Major (was: Blocker)
I agree, removing 'blocker' status.
> task-controller/configuration.c:get_values is broken
> ----------------------------------------------------
>
> Key: MAPREDUCE-970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-970
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-970.patch
>
>
> task-controller/configuration.c:get_values is supposed to return a char** with the last element set to NULL.
> It doesn't correctly handle empty config-values, #values as an exactly multiple of MAX_SIZE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-970)
task-controller/configuration.c:get_values is broken
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-970:
------------------------------------
Attachment: MAPREDUCE-970.patch
Straight-forward fix.
> task-controller/configuration.c:get_values is broken
> ----------------------------------------------------
>
> Key: MAPREDUCE-970
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-970
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tasktracker
> Affects Versions: 0.21.0
> Reporter: Arun C Murthy
> Assignee: Arun C Murthy
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: MAPREDUCE-970.patch
>
>
> task-controller/configuration.c:get_values is supposed to return a char** with the last element set to NULL.
> It doesn't correctly handle empty config-values, #values as an exactly multiple of MAX_SIZE.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.