[jira] [Closed] (OAK-4302) DefaultSyncContextTest contains duplicate test

["Davide Giannella (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davide Giannella closed OAK-4302.
---------------------------------

Bulk close for 1.5.2

> DefaultSyncContextTest contains duplicate test
> ----------------------------------------------
>
>                 Key: OAK-4302
>                 URL: https://issues.apache.org/jira/browse/OAK-4302
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: Francesco Mari
>            Assignee: angela
>            Priority: Trivial
>             Fix For: 1.5.2
>
>
> Some test methods in {{DefaultSyncContextTests}} are the same when compared line-by-line:
> * {{testCreateValueFromBytesArray}}, {{testCreateValueFromBinary}} and {{testCreateValueFromInputStream}};
> * {{testGetIdentityRefSyncGroup}} and {{testGetIdentityRefSyncUser}}.
> If these methods are actually testing different things because of a lucky state of the instance variable and an even luckier running order, they should be reworked to be independent. Otherwise, some of them should be removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)