[GitHub] [tvm] vinx13 opened a new pull request, #15816: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)

["vinx13 (via GitHub)" <gi...@apache.org>]

vinx13 opened a new pull request, #15816:
URL: https://github.com/apache/tvm/pull/15816

   This reverts commit 34637d7ee38f2636b1948548a39c15838d7a8db6.
   
   It is better not visiting fields of buffer when visiting `MatchBufferRegion` since it's more common that the buffer is not mutated in `StmtMutator` (it can be left to the derived passes to handle case by case). It is also consistent with visitor/mutator for `BufferLoad` and `BufferStore` that do not visit buffer fields.
   This fixes some broken tests in software pipelining where strides of some buffers in `MatchBufferRegion` are unintentionally mutated in-place.
   
   cc @yzh119 @tqchen @junrushao 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tqchen merged pull request #15816: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)

["tqchen (via GitHub)" <gi...@apache.org>]

tqchen merged PR #15816:
URL: https://github.com/apache/tvm/pull/15816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Lunderberg commented on pull request #15816: Revert "[TensorIR][Visitor] Visit buffer members in `match_buffer`'s in block visitor functions (#15153)

["Lunderberg (via GitHub)" <gi...@apache.org>]

Lunderberg commented on PR #15816:
URL: https://github.com/apache/tvm/pull/15816#issuecomment-1735692136

   As a potential third option, I think that we could have the buffers be visited at their point of definition.  That is, any `DeclBuffer` statement would have the buffer internals visited once, and the mutated buffer would then be substituted in at all points of use.  This would require the `DeclBuffer` to be present for all buffer objects, but that's part of the long-term plan anyways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org