You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/01 13:12:54 UTC

[GitHub] [arrow] NinaPeng commented on a change in pull request #9060: ARROW-11089: [C++][Gandiva] Support list datatype for gandiva UDF

NinaPeng commented on a change in pull request #9060:
URL: https://github.com/apache/arrow/pull/9060#discussion_r550767440



##########
File path: cpp/src/gandiva/annotator.cc
##########
@@ -46,15 +46,23 @@ FieldDescriptorPtr Annotator::MakeDesc(FieldPtr field, bool is_output) {
   int data_idx = buffer_count_++;
   int validity_idx = buffer_count_++;
   int offsets_idx = FieldDescriptor::kInvalidIdx;
+  int child_offsets_idx = FieldDescriptor::kInvalidIdx;

Review comment:
       as for list type array data:
   - list<binary-like> array data structure:
   ![image](https://user-images.githubusercontent.com/76817639/103439124-4f48fc80-4c75-11eb-89d5-9b94987e84f3.png)
   - list<primitive> array data structure:
   ![image](https://user-images.githubusercontent.com/76817639/103439220-06457800-4c76-11eb-99ab-7a55751e6941.png)
   
   
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org