You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by jcesarmobile <gi...@git.apache.org> on 2017/09/21 18:56:52 UTC
[GitHub] cordova-plugin-statusbar pull request #87: Make statusbar plugin handle iPho...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Make statusbar plugin handle iPhone X sensor housing
While maintaining the old behaviour in other devices
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
handle the iPhone X sensor housing while maintaining the old behaviour in other devices
### What testing has been done on this change?
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-statusbar patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-statusbar/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit f05e8fdce5f850d1a27a9b4b5ca5d3b179a2e6d0
Author: jcesarmobile <jc...@gmail.com>
Date: 2017-09-21T18:55:26Z
Make statusbar plugin handle iPhone X sensor housing
While maintaining the old behaviour in other devices
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: Make statusbar plugin handle iPhone X se...
Posted by danbucholtz <gi...@git.apache.org>.
Github user danbucholtz commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Working great here as well. Can we fast track this?
Thanks,
Dan
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by kgeoir <gi...@git.apache.org>.
Github user kgeoir commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Hello,
Any chance to have this one merged today?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar pull request #87: CB-13311: (iOS) Statusbar does no...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/87
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by wbmPeterScarborough <gi...@git.apache.org>.
Github user wbmPeterScarborough commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
How will I add this fix to my project when it's finished/tested?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by mbrookson <gi...@git.apache.org>.
Github user mbrookson commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
I've updated my plugin to 2.2.3 I am also seeing, as mentioned by @JavadMe, that if I add `viewport-fit=cover` to remove the top gap, the status bar appear correctly but the gap is at the bottom instead.
This is on an iPad Air, landscape
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by gslender <gi...@git.apache.org>.
Github user gslender commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@jcesarmobile I've updated https://issues.apache.org/jira/browse/CB-12886
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by TillaTheHun0 <gi...@git.apache.org>.
Github user TillaTheHun0 commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Can confirm this, along with adding `viewport-fit=cover` in the `meta` tag, resolves the issue on IPhone 7 running iOS 11. The spacing below the statusbar is no longer there. 👍
In my case, the spacing would initially be at the top right below the statusbar, until an input field gained focus and keyboard was displayed. The space would then move down to the bottom of the view.
Great work @jcesarmobile and team!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@gslender that's a different issue. Can you create a new one providing more information? if you can provide a sample project that would be awesome as I don't have much experience with ionic tabs
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: Make statusbar plugin handle iPhone X se...
Posted by mhartington <gi...@git.apache.org>.
Github user mhartington commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Tested this, working good!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by JavadMe <gi...@git.apache.org>.
Github user JavadMe commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@petemcwilliams
> I was not previously using cordova-plugin-wkwebview-engine
You were not or were you, I am using cordova-plugin-wkwebview-engine right now and the gap has moved to the bottom now after modifying the meta tag.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@gslender Can you create an issue on issues.cordova.io providing more information?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@wbmPeterScarborough it has been merged. You can use it removing the plugin and installing it from the github url `cordova plugin add https://github.com/apache/cordova-plugin-statusbar`
Hopefully we will release it next week
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by petemcwilliams <gi...@git.apache.org>.
Github user petemcwilliams commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
I was not previously using cordova-plugin-wkwebview-engine. I was also not seeing an issue with a gap at the bottom.
I was experiencing an issue with Ionic tab views content sections moving down the page about the size of the safe area this is the issue described in detail by gslender above.
When other fixes were put in place:
1) @wbmPeterScarborough it has been merged. You can use it removing the plugin and installing it from the github url cordova plugin add https://github.com/apache/cordova-plugin-statusbar
2) Added viewport-fit=cover to the line:
<meta name="viewport" content="viewport-fit=cover, width=device-width, initial-scale=1.0, minimum-scale=1.0, maximum-scale=1.0, user-scalable=no">
The white are at the top of the screen was fixed, I did not see a white area at the bottom of the screen. I had the issue with the Ionic tab pages. Which was resolved by installing
3) ionic cordova plugin add cordova-plugin-ionic-webview --save
4) following instructions on https://github.com/ionic-team/cordova-plugin-ionic-webview for config.xml
I have not been too concerned about iPhone X, only that there was a white space at the top of the app in IOS 11.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by JavadMe <gi...@git.apache.org>.
Github user JavadMe commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
@mbrookson Try`corodva-plugin-ionic-webview`, that reloved the problem for me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by EtienneLem <gi...@git.apache.org>.
Github user EtienneLem commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
Does it require a minimum `cordva` version? I’m running latest `cordova-ios` (4.5.1) but still using `cordova` 6.5.0.
The only way I can make it work is by manually calling `StatusBar.overlaysWebView(false)` and then `StatusBar.overlaysWebView(true)`, it doesn’t seem to be working by default when booting the app.
I’m using WKWebView and `master` for this plugin.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by gslender <gi...@git.apache.org>.
Github user gslender commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
I'm seeing a use case whereby content is pushed down again when switching between Ionic Tabs - ie content is rendered, and then janks as it is pushed down.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by stevehanson <gi...@git.apache.org>.
Github user stevehanson commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
It was also still seeing a white bar at the bottom of the screen after adding the `viewport-fit=cover` meta tag and updating StatusBar to the latest from master. Switching from `WKWebView` to [`cordova-plugin-ionic-webview`](https://github.com/ionic-team/cordova-plugin-ionic-webview) fixed the issue for me:
```
> ionic cordova plugin remove cordova-plugin-wkwebview-engine
> ionic cordova plugin add cordova-plugin-ionic-webview --save
```
I'm on `cordova-ios` 4.5.1. I did end up with a strange padding on one page in my app (only in iOS), which I fixed with:
```scss
margin-top: calc(0px - constant(safe-area-inset-top));
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-statusbar issue #87: CB-13311: (iOS) Statusbar does not overl...
Posted by petemcwilliams <gi...@git.apache.org>.
Github user petemcwilliams commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/87
I was having problems with tabs after the change to viewport-fit=cover as outlined by gslender above.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org