You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/03/15 03:49:22 UTC

[GitHub] [incubator-seatunnel] ruanwenjun opened a new pull request #1489: [Improvement][core] Optimize generic type

ruanwenjun opened a new pull request #1489:
URL: https://github.com/apache/incubator-seatunnel/pull/1489


   ## Purpose of this pull request
   Right now, we use a lot of generic type in seatunnel design, it's better to add the target type of each class.
   For example, use` List<String>` is better than use `List`.
   
   This pr is want to optimize the generic type using in seatunnel.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1489: [Improvement][core] Optimize generic type

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1489:
URL: https://github.com/apache/incubator-seatunnel/pull/1489


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1489: [Improvement][core] Optimize generic type

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1489:
URL: https://github.com/apache/incubator-seatunnel/pull/1489#issuecomment-1068165915


   @ruanwenjun Please resolve the conflicting files, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #1489: [Improvement][core] Optimize generic type

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on pull request #1489:
URL: https://github.com/apache/incubator-seatunnel/pull/1489#issuecomment-1068750425


   Overall looks good, @CalvinKirs PTAL, Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1489: [Improvement][core] Optimize generic type

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #1489:
URL: https://github.com/apache/incubator-seatunnel/pull/1489#issuecomment-1068253890


   > @ruanwenjun Please resolve the conflicting files, thanks
   
   Thanks, PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org