You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/03/21 15:04:35 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4681: Cxf-soap: Extend test coverage with Ssl scenario #4679
JiriOndrusek opened a new pull request, #4681:
URL: https://github.com/apache/camel-quarkus/pull/4681
fixes https://github.com/apache/camel-quarkus/issues/4679
Important fact: Global ssl tests require camel ( -> quarkus) to be restarted (to avoid persisting of some context values).
Therefore tests are separated into several test files and forces Quarkus to be restarted by using different `QuarkusTestProfile` .
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4681: Cxf-soap: Extend test coverage with Ssl scenario #4679
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4681:
URL: https://github.com/apache/camel-quarkus/pull/4681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on a diff in pull request #4681: Cxf-soap: Extend test coverage with Ssl scenario #4679
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #4681:
URL: https://github.com/apache/camel-quarkus/pull/4681#discussion_r1144675759
##########
integration-test-groups/cxf-soap/cxf-soap-ssl/src/main/resources/application.properties:
##########
@@ -0,0 +1,29 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+quarkus.cxf.path=/soapservice
+quarkus.native.resources.includes=truststore-client.jks,truststore-server.jks,truststore-wrong.jks
+
+# Workaround for https://github.com/apache/camel-quarkus/issues/4603
+# Should not be needed with the Quarkus release coming after 3.0.0.Alpha5
+quarkus.jaxb.validate-jaxb-context = false
Review Comment:
Thanks! Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #4681: Cxf-soap: Extend test coverage with Ssl scenario #4679
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #4681:
URL: https://github.com/apache/camel-quarkus/pull/4681#discussion_r1144638663
##########
integration-test-groups/cxf-soap/cxf-soap-ssl/src/main/resources/application.properties:
##########
@@ -0,0 +1,29 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+quarkus.cxf.path=/soapservice
+quarkus.native.resources.includes=truststore-client.jks,truststore-server.jks,truststore-wrong.jks
+
+# Workaround for https://github.com/apache/camel-quarkus/issues/4603
+# Should not be needed with the Quarkus release coming after 3.0.0.Alpha5
+quarkus.jaxb.validate-jaxb-context = false
Review Comment:
```suggestion
```
Could you please remove this? It is not needed anymore with Quarkus 3.0.0.Alpha6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org