You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:38:27 UTC
[GitHub] [mina-vysper] karimhm opened a new pull request #20: Fix the default XML lang tag of `DefaultServerRuntimeContext`
karimhm opened a new pull request #20:
URL: https://github.com/apache/mina-vysper/pull/20
According to [**RFC 6120**](https://xmpp.org/rfcs/rfc6120.html#streams-attr-xmllang) the `xml:lang` must conform to the language identifier format defined in [**BCP 47, RFC 5646**](https://tools.ietf.org/html/rfc5646).
This PR fixes this issue by changing the previously set value `en_US` to `en`. The country code is omitted from this PE to prevent future possible issue. The correct format of *US English* would be`en-US`.
> Some servers will refuse to communicate with `Apache Mina Vysper` if the language tag is not correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-vysper] reda-alaoui commented on pull request #20: Fix the default XML lang tag of `DefaultServerRuntimeContext`
Posted by GitBox <gi...@apache.org>.
reda-alaoui commented on pull request #20:
URL: https://github.com/apache/mina-vysper/pull/20#issuecomment-756124172
Thank you !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-vysper] reda-alaoui merged pull request #20: Fix the default XML lang tag of `DefaultServerRuntimeContext`
Posted by GitBox <gi...@apache.org>.
reda-alaoui merged pull request #20:
URL: https://github.com/apache/mina-vysper/pull/20
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org