You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/20 23:41:06 UTC

[GitHub] [flink] chinmayms commented on a diff in pull request #19540: [FLINK-27333] Flink filesystems hadoop version upgrade to 3.3.2

chinmayms commented on code in PR #19540:
URL: https://github.com/apache/flink/pull/19540#discussion_r854653554


##########
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java:
##########
@@ -94,6 +94,11 @@ protected URI getInitURI(URI fsUri, org.apache.hadoop.conf.Configuration hadoopC
     @Override
     protected S3AccessHelper getS3AccessHelper(FileSystem fs) {
         final S3AFileSystem s3Afs = (S3AFileSystem) fs;
-        return new HadoopS3AccessHelper(s3Afs, s3Afs.getConf());
+        return new HadoopS3AccessHelper(
+                s3Afs,
+                s3Afs.getConf(),
+                s3Afs.createStoreContext().getInstrumentation(),

Review Comment:
   Makes sense. Changed it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org