You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by ng...@apache.org on 2007/02/16 17:51:00 UTC
svn commit: r508488 -
/webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java
Author: ngallardo
Date: Fri Feb 16 08:50:59 2007
New Revision: 508488
URL: http://svn.apache.org/viewvc?view=rev&rev=508488
Log:
cleaning up comments
Modified:
webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java
Modified: webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java?view=diff&rev=508488&r1=508487&r2=508488
==============================================================================
--- webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java (original)
+++ webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/core/controller/AxisInvocationController.java Fri Feb 16 08:50:59 2007
@@ -91,13 +91,6 @@
// case an anonymous AxisService with anoymouns AxisOperations for the supported
// MEPs will be created; and it is that anonymous operation name which needs to
// be specified
- // TODO: Fix this logic once AxisService is created via annoations and not just WSDL
- // If ServiceDesc.axisService is null, then we created an Annon Service and operations in
- // ServiceDelegate.getServiceClient(), and that is what the service client points to.
- // Therefore, we need to use the annonymous operation name in that case, so the anonymous service client will find
- // the anonymous AxisOperation on that service.
- // This means the ServiceDesc was not build with WSDL, and so there are no Axis objects attached to them
- // i.e the OperationDesc.axisOperation == null
QName operationName = getOperationNameToUse(request, ServiceClient.ANON_OUT_IN_OP);
// TODO: Will the ServiceClient stick around on the InvocationContext
@@ -169,13 +162,6 @@
// case an anonymous AxisService with anoymouns AxisOperations for the supported
// MEPs will be created; and it is that anonymous operation name which needs to
// be specified
- // TODO: Fix this logic once AxisService is created via annoations and not just WSDL
- // If ServiceDesc.axisService is null, then we created an Annon Service and operations in
- // ServiceDelegate.getServiceClient(), and that is what the service client points to.
- // Therefore, we need to use the annonymous operation name in that case, so the anonymous service client will find
- // the anonymous AxisOperation on that service.
- // This means the ServiceDesc was not build with WSDL, and so there are no Axis objects attached to them
- // i.e the OperationDesc.axisOperation == null
QName operationName = getOperationNameToUse(request, ServiceClient.ANON_OUT_ONLY_OP);
InvocationContext ic = request.getInvocationContext();
@@ -213,13 +199,6 @@
// case an anonymous AxisService with anoymouns AxisOperations for the supported
// MEPs will be created; and it is that anonymous operation name which needs to
// be specified
- // TODO: Fix this logic once AxisService is created via annoations and not just WSDL
- // If ServiceDesc.axisService is null, then we created an Annon Service and operations in
- // ServiceDelegate.getServiceClient(), and that is what the service client points to.
- // Therefore, we need to use the annonymous operation name in that case, so the anonymous service client will find
- // the anonymous AxisOperation on that service.
- // This means the ServiceDesc was not build with WSDL, and so there are no Axis objects attached to them
- // i.e the OperationDesc.axisOperation == null
QName operationName = getOperationNameToUse(request, ServiceClient.ANON_OUT_IN_OP);
// TODO: Will the ServiceClient stick around on the InvocationContext
@@ -297,13 +276,6 @@
// case an anonymous AxisService with anoymouns AxisOperations for the supported
// MEPs will be created; and it is that anonymous operation name which needs to
// be specified
- // TODO: Fix this logic once AxisService is created via annoations and not just WSDL
- // If ServiceDesc.axisService is null, then we created an Annon Service and operations in
- // ServiceDelegate.getServiceClient(), and that is what the service client points to.
- // Therefore, we need to use the annonymous operation name in that case, so the anonymous service client will find
- // the anonymous AxisOperation on that service.
- // This means the ServiceDesc was not build with WSDL, and so there are no Axis objects attached to them
- // i.e the OperationDesc.axisOperation == null
QName operationName = getOperationNameToUse(request, ServiceClient.ANON_OUT_IN_OP);
// TODO: Will the ServiceClient stick around on the InvocationContext
@@ -526,18 +498,6 @@
}
/*
- private Message createMessageFromOM(OMElement om) throws WebServiceException {
- try {
- MessageFactory mf = (MessageFactory) FactoryRegistry.getFactory(MessageFactory.class);
- Message msg = mf.createFrom(om);
- return msg;
- } catch (Exception e) {
- throw ExceptionFactory.makeWebServiceException(e);
- }
- }
- */
-
- /*
* TODO: This is a first pass at filtering the properties that are set on the
* RequestContext. Right now it's called during the invoke, but needs to be
* moved over to when the property is set. This should not be in the path
@@ -601,9 +561,6 @@
}
}
- // TODO: This method may need to be removed or refactored when the ServiceDescription can
- // create the AxisService hierachy using annotations. Currently the AxisService hierachy is
- // only created under a ServiceDescription if WSDL is supplied
private static QName getOperationNameToUse(MessageContext requestMsgCtx, QName defaultOpName) {
// We need the qname of the operation being invoked to know which
// AxisOperation the OperationClient should be based on.
@@ -612,15 +569,6 @@
// case an anonymous AxisService with anoymouns AxisOperations for the supported
// MEPs will be created; and it is that anonymous operation name which needs to
// be specified
- // TODO: Fix this logic once AxisService is created via annoations and not just WSDL
- // If ServiceDesc.axisService is null (which currently happens if no WSDL
- // was supplied when the ServiceDesc is created), then we created an annonymous Service and operations in
- // ServiceDelegate.getServiceClient(), and that is what the service client used in the inovke points to.
- // Therefore, we need to use the annonymous operation name in that case, so the anonymous service client will find
- // the anonymous AxisOperation on that service.
- // The check below for this case is that the AxisOperation is null, since all Axis description
- // objects (including AxisOperation) are only created if WSDL was use to create the ServiceDesc.
- // This will probably need to change once Axis descriptions are also created from annotions.
QName operationName = null;
OperationDescription opDesc = requestMsgCtx.getOperationDescription();
if (opDesc != null && opDesc.getAxisOperation() != null)
---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org