[GitHub] [incubator-hudi] xushiyan commented on a change in pull request #987: Support bulkinsert in HDFSParquetImporter

[GitBox <gi...@apache.org>]

xushiyan commented on a change in pull request #987: Support bulkinsert in HDFSParquetImporter
URL: https://github.com/apache/incubator-hudi/pull/987#discussion_r340687862
 
 

 ##########
 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java
 ##########
 @@ -64,20 +65,17 @@
 
   private static volatile Logger log = LogManager.getLogger(HDFSParquetImporter.class);
 
-  public static final SimpleDateFormat PARTITION_FORMATTER = new SimpleDateFormat("yyyy/MM/dd");
-  private static volatile Logger logger = LogManager.getLogger(HDFSParquetImporter.class);
+  private static final DateTimeFormatter PARTITION_FORMATTER = DateTimeFormatter.ofPattern("yyyy/MM/dd")
+      .withZone(ZoneOffset.UTC);
   private final Config cfg;
   private transient FileSystem fs;
   /**
    * Bag of properties with source, hoodie client, key generator etc.
    */
   private TypedProperties props;
 
-  public HDFSParquetImporter(Config cfg) throws IOException {
+  public HDFSParquetImporter(Config cfg) {
     this.cfg = cfg;
-    this.props = cfg.propsFilePath == null ? UtilHelpers.buildProperties(cfg.configs)
-        : UtilHelpers.readConfig(fs, new Path(cfg.propsFilePath), cfg.configs).getConfig();
 
 Review comment:
   `fs` is not initialized at this point.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services