[GitHub] [lucene-solr] gerlowskija commented on pull request #2056: SOLR-14971: Handle atomic-removes on uncommitted docs

[GitBox <gi...@apache.org>]

gerlowskija commented on pull request #2056:
URL: https://github.com/apache/lucene-solr/pull/2056#issuecomment-722539440


   I thought of doing a `toNativeType` conversion on the "original" Collection, but didn't like how it changed SolrInputDocument values for field-vals supposedly unaffected by the operation (e.g. an atomic remove of 1 of 5 values would change all 5 to native-types).  I was leery of what problems that might cause downstream.
   
   But if there are input edge cases I'm missing in the current iteration, maybe it's worth revisiting that approach.  I'll take a look at that and some of the other things you mentioned (esp. add-distinct reproduction).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org