[GitHub] [beam] suztomo commented on a change in pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

[GitBox <gi...@apache.org>]

suztomo commented on a change in pull request #12695:
URL: https://github.com/apache/beam/pull/12695#discussion_r479445387



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerSchema.java
##########
@@ -169,7 +169,9 @@ private static Type parseSpannerType(String spannerType) {
       if ("DATE".equals(spannerType)) {
         return Type.date();
       }
-
+      if ("NUMERIC".equals(spannerType)) {
+        return Type.numeric();
+      }

Review comment:
       @terryxian78 Is this new?

##########
File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/GcpApiSurfaceTest.java
##########
@@ -65,11 +65,13 @@ public void testGcpApiSurface() throws Exception {
             classesInPackage("com.google.bigtable.v2"),
             classesInPackage("com.google.cloud.bigquery.storage.v1beta1"),
             classesInPackage("com.google.cloud.bigtable.config"),
+            classesInPackage("com.google.common.collect"),

Review comment:
       You may want to be more specific here. This includes all the classes in Guava's collection, ImmutableList, ImmutableSet, etc. I believe Beam team has intentionally avoided the classes to be exposed as APIs.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org