You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/09/14 08:05:21 UTC
[GitHub] incubator-zeppelin pull request: Fix HTML/ANGULAR extra rendering
GitHub user corneadoug opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/304
Fix HTML/ANGULAR extra rendering
1) The HTML and ANGULAR type of results were rendered for every change on the paragraph (ex: when editor is hidden)
I also took care of removing a few unnecessary variables.
2) When we run the paragraph, we received 3 to 4 times a response from the server
(1st from the run paragraph function, then one for each status change). I removed the run paragraph response since the status will take care of it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/multiRendering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit ad6470294f1b4e33b172c8b847f1540982b1dbfa
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-02T02:37:59Z
Remove Ace warning in console
commit 24594f2c13574a2cf13849593e93f0141b201276
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-11T07:42:02Z
Stop rendering HTML and Angular if result wasn't refreshed
commit 144d40aa565aea682f65760d1d59505b79716f13
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-14T04:58:48Z
Remove useless broadcastNote
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix HTML/ANGULAR extra rendering
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix HTML/ANGULAR extra rendering
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/304#issuecomment-140019786
Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix HTML/ANGULAR extra rendering
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/304
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Fix HTML/ANGULAR extra rendering
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/304
Fix HTML/ANGULAR extra rendering
1) The HTML and ANGULAR type of results were rendered for every change on the paragraph (ex: when editor is hidden)
I also took care of removing a few unnecessary variables.
2) When we run the paragraph, we received 3 to 4 times a response from the server
(1st from the run paragraph function, then one for each status change). I removed the run paragraph response since the status will take care of it.
We might want to consider in the future replacing the return value of runParagraph by the paragraph only instead of the full note.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/multiRendering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit da113c39143109bbba3407fdca2cef5850db34e2
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-02T02:37:59Z
Remove Ace warning in console
commit 0a0cd255755c0890a7e933a9eb9ac84d6fee2f53
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-11T07:42:02Z
Stop rendering HTML and Angular if result wasn't refreshed
commit 245b0457a557821bb34aff5ad20e9ed3c90054d1
Author: Damien Corneau <co...@gmail.com>
Date: 2015-09-14T04:58:48Z
Remove useless broadcastNote
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---