You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/13 22:13:27 UTC
[GitHub] [airflow] potiuk opened a new pull request #22226: Add documentation for RC2 package release for Feb 2022
potiuk opened a new pull request #22226:
URL: https://github.com/apache/airflow/pull/22226
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1067276774
Should be ready for re-review @eladkal :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #22226:
URL: https://github.com/apache/airflow/pull/22226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1066698572
I also used the opportunity to move all the static data from `setup.py` to `setup.cfg` generated for providers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1066697757
Hey @eladkal - I think re-review will be needed :) as after the Trove Classifiers became available I decided to release all packages again - with the Trove classifier included.
I also converted it to draft as I found out during preparation that there was a backwards incompatible change implemented in #22112 in a number of providers that makes them only compatible with the upcoming 2.3.0+, this needs to be fixed before we release the providers. See https://github.com/apache/airflow/pull/22112#issuecomment-1066685670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#discussion_r826110247
##########
File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2
##########
@@ -23,19 +23,54 @@
[metadata]
-name = Airflow {{ PROVIDER_TYPE }}: {{ PACKAGE_PIP_NAME }}
+name = {{ PACKAGE_PIP_NAME }}
summary = {{ PROVIDER_TYPE }} for Apache Airflow. Implements {{ PACKAGE_PIP_NAME }} package
-description_file = README.md
-author = Apache Airflow PMC
+description = {{ PROVIDER_TYPE }} package {{ PACKAGE_PIP_NAME }} for Apache Airflow
+long_description = file: README.rst
+long_description_content_type = text/x-rst
+author = Apache Software Foundation
author_email = dev@airflow.apache.org
-license = Apache License, Version 2.0
+url = https://airflow.apache.org/
+download_url = https://archive.apache.org/dist/airflow/{{ PROVIDERS_FOLDER }}
+license = Apache License 2.0
license_files =
LICENSE
NOTICE
+classifiers =
+ Development Status :: 5 - Production/Stable
+ Environment :: Console
+ Environment :: Web Environment
+ Intended Audience :: Developers
+ Intended Audience :: System Administrators
+ Framework :: Apache Airflow
Review comment:
Projects with Django framework: https://pypi.org/search/?q=&o=&c=Framework+%3A%3A+Django
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#discussion_r826108909
##########
File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2
##########
@@ -23,19 +23,54 @@
[metadata]
-name = Airflow {{ PROVIDER_TYPE }}: {{ PACKAGE_PIP_NAME }}
+name = {{ PACKAGE_PIP_NAME }}
summary = {{ PROVIDER_TYPE }} for Apache Airflow. Implements {{ PACKAGE_PIP_NAME }} package
-description_file = README.md
-author = Apache Airflow PMC
+description = {{ PROVIDER_TYPE }} package {{ PACKAGE_PIP_NAME }} for Apache Airflow
+long_description = file: README.rst
+long_description_content_type = text/x-rst
+author = Apache Software Foundation
author_email = dev@airflow.apache.org
-license = Apache License, Version 2.0
+url = https://airflow.apache.org/
+download_url = https://archive.apache.org/dist/airflow/{{ PROVIDERS_FOLDER }}
+license = Apache License 2.0
license_files =
LICENSE
NOTICE
+classifiers =
+ Development Status :: 5 - Production/Stable
+ Environment :: Console
+ Environment :: Web Environment
+ Intended Audience :: Developers
+ Intended Audience :: System Administrators
+ Framework :: Apache Airflow
Review comment:
Yup, agreed, we should add it.
I consider it as "Projects using Apache Airflow"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#discussion_r826110888
##########
File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2
##########
@@ -23,19 +23,54 @@
[metadata]
-name = Airflow {{ PROVIDER_TYPE }}: {{ PACKAGE_PIP_NAME }}
+name = {{ PACKAGE_PIP_NAME }}
summary = {{ PROVIDER_TYPE }} for Apache Airflow. Implements {{ PACKAGE_PIP_NAME }} package
-description_file = README.md
-author = Apache Airflow PMC
+description = {{ PROVIDER_TYPE }} package {{ PACKAGE_PIP_NAME }} for Apache Airflow
+long_description = file: README.rst
+long_description_content_type = text/x-rst
+author = Apache Software Foundation
author_email = dev@airflow.apache.org
-license = Apache License, Version 2.0
+url = https://airflow.apache.org/
+download_url = https://archive.apache.org/dist/airflow/{{ PROVIDERS_FOLDER }}
+license = Apache License 2.0
license_files =
LICENSE
NOTICE
+classifiers =
+ Development Status :: 5 - Production/Stable
+ Environment :: Console
+ Environment :: Web Environment
+ Intended Audience :: Developers
+ Intended Audience :: System Administrators
+ Framework :: Apache Airflow
Review comment:
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#discussion_r825875581
##########
File path: dev/provider_packages/SETUP_TEMPLATE.cfg.jinja2
##########
@@ -23,19 +23,54 @@
[metadata]
-name = Airflow {{ PROVIDER_TYPE }}: {{ PACKAGE_PIP_NAME }}
+name = {{ PACKAGE_PIP_NAME }}
summary = {{ PROVIDER_TYPE }} for Apache Airflow. Implements {{ PACKAGE_PIP_NAME }} package
-description_file = README.md
-author = Apache Airflow PMC
+description = {{ PROVIDER_TYPE }} package {{ PACKAGE_PIP_NAME }} for Apache Airflow
+long_description = file: README.rst
+long_description_content_type = text/x-rst
+author = Apache Software Foundation
author_email = dev@airflow.apache.org
-license = Apache License, Version 2.0
+url = https://airflow.apache.org/
+download_url = https://archive.apache.org/dist/airflow/{{ PROVIDERS_FOLDER }}
+license = Apache License 2.0
license_files =
LICENSE
NOTICE
+classifiers =
+ Development Status :: 5 - Production/Stable
+ Environment :: Console
+ Environment :: Web Environment
+ Intended Audience :: Developers
+ Intended Audience :: System Administrators
+ Framework :: Apache Airflow
Review comment:
I am not 100% sure if we want to add also "Framework :: Apache Airflow" as classifier here. I guess we do (otherwise only "apache-airlfow" package would be applicable to have it) @ashb @kaxil WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22226: Add documentation for Classifier release for March 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1066700856
(BTW: pressing the "." in the UI and opening web-browser-vscode makes it much easier to review such big PR. It takes quite a bit time to load but once it does, it's much more usable).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #22226: Add documentation for RC2 package release for Feb 2022
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1066192737
Docs for RC2 of Feb providers:
* amazon and dbt.cloud - bug fixes
* snowflake and databricks- Upcoming Python 3.10-related changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #22226: Add documentation for RC2 package release for Feb 2022
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #22226:
URL: https://github.com/apache/airflow/pull/22226#issuecomment-1066206473
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org