You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/01 21:47:13 UTC
[GitHub] [ozone] tanvipenumudy opened a new pull request #3266: HDDS-6457. Add freon command to run r/w mix workload and get lock metrics
tanvipenumudy opened a new pull request #3266:
URL: https://github.com/apache/ozone/pull/3266
## What changes were proposed in this pull request?
To develop a new Ozone Freon tool command where one can configure or pass an argument to generate/run a synthetic read and write operation mix workload on a bucket and print the lock read/write waiting/held time metrics.
**Step 1:** Create `fileCountForRead` (defaultValue = 1000) files under _rootPath/readPath_ directory
**Step 2:** Start `readThreadCount` (defaultValue = 90) concurrent read threads
 each new Thread (() -> {
  for(1...`numOfReadOperations` (defaultValue = 50))
   fileSystem.listStatus(_rootPath/readPath_)
 }
**Step 3:** Start `writeThreadCount` (defaultValue = 10) concurrent write threads
 each new Thread (() -> {
  for(1...`numOfWriteOperations` (defaultValue = 10))
   createFile(_rootPath/writePath/file-random-keypath_)
 }
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-6457
## How was this patch tested?
Added integration tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] JyotinderSingh commented on a change in pull request #3266: HDDS-6457. Add freon command to run r/w mix workload and get lock metrics
Posted by GitBox <gi...@apache.org>.
JyotinderSingh commented on a change in pull request #3266:
URL: https://github.com/apache/ozone/pull/3266#discussion_r841084763
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmBucketReadWriteOps.java
##########
@@ -0,0 +1,250 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+import java.io.IOException;
+import java.net.URI;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+
+/**
+ * Synthetic read/write operations workload generator tool.
+ */
+@Command(name = "obrwo",
+ aliases = "om-bucket-read-write-ops",
+ description = "Creates files, performs respective read/write " +
+ "operations to measure lock performance.",
+ versionProvider = HddsVersionProvider.class,
+ mixinStandardHelpOptions = true,
+ showDefaultValues = true)
+
+public class OmBucketReadWriteOps extends BaseFreonGenerator
+ implements Callable<Void> {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OmBucketReadWriteOps.class);
+
+ @Option(names = {"-P", "root-path", "--rootPath"},
Review comment:
```suggestion
@Option(names = {"-P", "--root-path", "--rootPath"},
```
minor typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] tanvipenumudy commented on a change in pull request #3266: HDDS-6457. Add freon command to run r/w mix workload and get lock metrics
Posted by GitBox <gi...@apache.org>.
tanvipenumudy commented on a change in pull request #3266:
URL: https://github.com/apache/ozone/pull/3266#discussion_r841165532
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/OmBucketReadWriteOps.java
##########
@@ -0,0 +1,250 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.hadoop.ozone.freon;
+
+import com.codahale.metrics.Timer;
+import org.apache.commons.lang3.RandomStringUtils;
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hdds.cli.HddsVersionProvider;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import picocli.CommandLine.Command;
+import picocli.CommandLine.Option;
+
+import java.io.IOException;
+import java.net.URI;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+
+/**
+ * Synthetic read/write operations workload generator tool.
+ */
+@Command(name = "obrwo",
+ aliases = "om-bucket-read-write-ops",
+ description = "Creates files, performs respective read/write " +
+ "operations to measure lock performance.",
+ versionProvider = HddsVersionProvider.class,
+ mixinStandardHelpOptions = true,
+ showDefaultValues = true)
+
+public class OmBucketReadWriteOps extends BaseFreonGenerator
+ implements Callable<Void> {
+
+ private static final Logger LOG =
+ LoggerFactory.getLogger(OmBucketReadWriteOps.class);
+
+ @Option(names = {"-P", "root-path", "--rootPath"},
Review comment:
Fixed the typo, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org