You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by GitBox <gi...@apache.org> on 2019/03/27 15:54:29 UTC

[GitHub] [samza] prateekm commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass

prateekm commented on a change in pull request #978: SAMZA-1733 : Making MetricsSnapshotReporter look for appclass then taskclass
URL: https://github.com/apache/samza/pull/978#discussion_r269637384
 
 

 ##########
 File path: samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
 ##########
 @@ -45,10 +45,8 @@ class MetricsSnapshotReporterFactory extends MetricsReporterFactory with Logging
     val jobId = config
       .getJobId
 
-    val taskClass = config
-      .getTaskClass
-      .orElse(Option(new ApplicationConfig(config).getAppClass()))
-      .getOrElse(throw new SamzaException("No task or app class defined for config."))
+    val taskClass = Option(new ApplicationConfig(config).getAppClass())
 
 Review comment:
   @rmatharu Just wondering, what issue does changing the order fix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services