You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "jonvex (via GitHub)" <gi...@apache.org> on 2023/01/28 00:01:16 UTC
[GitHub] [hudi] jonvex opened a new pull request, #7765: [MINOR] make getting log block format standardized
jonvex opened a new pull request, #7765:
URL: https://github.com/apache/hudi/pull/7765
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7765: [MINOR] make getting log block format standardized
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7765:
URL: https://github.com/apache/hudi/pull/7765#issuecomment-1422418327
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15017",
"triggerID" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b6759aaa73bf1ffe5489174198716a68ec861f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7765: [MINOR] make getting log block format standardized
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7765:
URL: https://github.com/apache/hudi/pull/7765#issuecomment-1421758252
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15017",
"triggerID" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b6759aaa73bf1ffe5489174198716a68ec861f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15017)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on a diff in pull request #7765: [MINOR] make getting log block format standardized
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #7765:
URL: https://github.com/apache/hudi/pull/7765#discussion_r1335235764
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1896,6 +1897,26 @@ public Option<HoodieLogBlock.HoodieLogBlockType> getLogDataBlockFormat() {
.map(HoodieLogBlock.HoodieLogBlockType::fromId);
}
+ public HoodieLogBlock.HoodieLogBlockType pickLogDataBlockFormat(HoodieFileFormat format) {
Review Comment:
nit: rename the argument from `format` to `baseFileFormat`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -1896,6 +1897,26 @@ public Option<HoodieLogBlock.HoodieLogBlockType> getLogDataBlockFormat() {
.map(HoodieLogBlock.HoodieLogBlockType::fromId);
}
+ public HoodieLogBlock.HoodieLogBlockType pickLogDataBlockFormat(HoodieFileFormat format) {
+ Option<HoodieLogBlock.HoodieLogBlockType> logBlockTypeOpt = getLogDataBlockFormat();
+ if (logBlockTypeOpt.isPresent()) {
+ return logBlockTypeOpt.get();
+ }
+
+ // Fallback to deduce data-block type based on the base file format
+ switch (format) {
+ case PARQUET:
+ return HoodieLogBlock.HoodieLogBlockType.PARQUET_DATA_BLOCK;
Review Comment:
This switches the default log format from Avro to Parquet. I'm okay with this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7765: [MINOR] make getting log block format standardized
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #7765:
URL: https://github.com/apache/hudi/pull/7765#issuecomment-1421739209
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b5b6759aaa73bf1ffe5489174198716a68ec861f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b5b6759aaa73bf1ffe5489174198716a68ec861f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org