You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/10/30 22:26:52 UTC
Review Request 27395: Fixed test namespace setter compilation
exclusion on OSX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27395/
-----------------------------------------------------------
Review request for mesos and Ian Downes.
Bugs: MESOS-2015
https://issues.apache.org/jira/browse/MESOS-2015
Repository: mesos-git
Description
-------
see summary
Diffs
-----
src/Makefile.am 374f284
Diff: https://reviews.apache.org/r/27395/diff/
Testing
-------
make check (on OSX)
Thanks,
Till Toenshoff
Re: Review Request 27395: Fixed test namespace setter compilation
exclusion on OSX.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27395/#review59267
-----------------------------------------------------------
Patch looks great!
Reviews applied: [27395]
All tests passed.
- Mesos ReviewBot
On Oct. 30, 2014, 9:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27395/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-2015
> https://issues.apache.org/jira/browse/MESOS-2015
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 374f284
>
> Diff: https://reviews.apache.org/r/27395/diff/
>
>
> Testing
> -------
>
> make check (on OSX)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27395: Fixed test namespace setter compilation
exclusion on OSX.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27395/#review59334
-----------------------------------------------------------
Ship it!
- Bernd Mathiske
On Oct. 30, 2014, 2:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27395/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 2:26 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-2015
> https://issues.apache.org/jira/browse/MESOS-2015
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 374f284
>
> Diff: https://reviews.apache.org/r/27395/diff/
>
>
> Testing
> -------
>
> make check (on OSX)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27395: Fixed test namespace setter compilation
exclusion on OSX.
Posted by Till Toenshoff <to...@me.com>.
> On Oct. 31, 2014, 7:36 p.m., Ian Downes wrote:
> > src/Makefile.am, line 1158
> > <https://reviews.apache.org/r/27395/diff/1/?file=743662#file743662line1158>
> >
> > are these spaces or tabs?
spaces
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27395/#review59388
-----------------------------------------------------------
On Oct. 30, 2014, 9:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27395/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 9:26 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-2015
> https://issues.apache.org/jira/browse/MESOS-2015
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 374f284
>
> Diff: https://reviews.apache.org/r/27395/diff/
>
>
> Testing
> -------
>
> make check (on OSX)
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 27395: Fixed test namespace setter compilation
exclusion on OSX.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27395/#review59388
-----------------------------------------------------------
Ship it!
src/Makefile.am
<https://reviews.apache.org/r/27395/#comment100655>
are these spaces or tabs?
- Ian Downes
On Oct. 30, 2014, 2:26 p.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27395/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 2:26 p.m.)
>
>
> Review request for mesos and Ian Downes.
>
>
> Bugs: MESOS-2015
> https://issues.apache.org/jira/browse/MESOS-2015
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> src/Makefile.am 374f284
>
> Diff: https://reviews.apache.org/r/27395/diff/
>
>
> Testing
> -------
>
> make check (on OSX)
>
>
> Thanks,
>
> Till Toenshoff
>
>