You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Regis Xu (JIRA)" <ji...@apache.org> on 2008/09/26 08:31:44 UTC

[jira] Created: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

[classlib][luni] - add tests for self referencing Collection
------------------------------------------------------------

                 Key: HARMONY-5988
                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
             Project: Harmony
          Issue Type: Test
          Components: Classlib
    Affects Versions: 5.0M7
            Reporter: Regis Xu
             Fix For: 5.0M8
         Attachments: HARMONY-5988.diff

add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu closed HARMONY-5988.
-----------------------------


Verified. Thanks Tim.
BTW, I notice that newline character of HashMapTest.java and CollectionsTest.java changed from unix to windows. That cause "svn diff" show the whole old/new files. Is there any conventions about which EOL is perferred?

> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634811#action_12634811 ] 

Regis Xu commented on HARMONY-5988:
-----------------------------------

Got it. Thanks your explanation!

> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu updated HARMONY-5988:
------------------------------

    Attachment: HARMONY-5988.diff

Would anyone want to try this?

> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison resolved HARMONY-5988.
----------------------------------

    Resolution: Fixed

Thanks Regis,

Patch applied to LUNI module at repo revision r699249.

Please check it was applied as you expected.


> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634807#action_12634807 ] 

Tim Ellison commented on HARMONY-5988:
--------------------------------------

All source files should have "svn:eol-style" property set to "native" so that the EOL is adapted for all platforms.

I've fixed 
    modules\luni\src\test\api\common\org\apache\harmony\luni\tests\java\util\HashMapTest.java  
    modules\luni\src\test\api\common\org\apache\harmony\luni\tests\java\util\ArrayListTest.java  
    modules\luni\src\test\api\common\org\apache\harmony\luni\tests\java\util\CollectionsTest.java  
at revision r699262  


> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5988) [classlib][luni] - add tests for self referencing Collection

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison reassigned HARMONY-5988:
------------------------------------

    Assignee: Tim Ellison

> [classlib][luni] - add tests for self referencing Collection
> ------------------------------------------------------------
>
>                 Key: HARMONY-5988
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5988
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M7
>            Reporter: Regis Xu
>            Assignee: Tim Ellison
>             Fix For: 5.0M8
>
>         Attachments: HARMONY-5988.diff
>
>
> add tests for self referencing, ArrayList, HashSet and HashMap, and clean CollectionsTest.java to fit harmony code conventions

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.