You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Navis Ryu <na...@nexr.com> on 2011/08/05 10:30:34 UTC

Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1304/
-----------------------------------------------------------

Review request for hive.


Summary
-------

It's very very rare case.. just for code completeness.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/Context.java 1a1ffc5 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java b278ffe 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java fe95cb1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinResolver.java c8194a8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java dc9ab1b 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestJoinTree.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestUtil.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1304/diff


Testing
-------


Thanks,

Navis


Re: Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1304/
-----------------------------------------------------------

(Updated 2011-11-15 08:13:13.468713)


Review request for hive and namit jain.


Changes
-------

Rebased patch to trunk


Summary (updated)
-------

It's very very rare case.. just for code completeness.

<added> 

This case had happened in real query. It was not as rare as we thought. Fix this plz.


This addresses bug HIVE-2253.
    https://issues.apache.org/jira/browse/HIVE-2253


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d60ba09 
  ql/src/test/queries/clientpositive/mergejoins.q PRE-CREATION 
  ql/src/test/results/clientpositive/mergejoins.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/1304/diff


Testing (updated)
-------

Test case added : clientpositive/mergejoins.q


Thanks,

Navis


Re: Review Request: HIVE-2253 In some exceptional case, join tree fails to be merged, making additional MR

Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1304/
-----------------------------------------------------------

(Updated 2011-08-05 08:33:16.910890)


Review request for hive.


Changes
-------

mistake


Summary
-------

It's very very rare case.. just for code completeness.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java dc9ab1b 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestJoinTree.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/parse/TestUtil.java PRE-CREATION 

Diff: https://reviews.apache.org/r/1304/diff


Testing
-------


Thanks,

Navis