You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/09 01:53:44 UTC

[GitHub] betodealmeida commented on a change in pull request #4572: Legend for deck.gl scatterplot

betodealmeida commented on a change in pull request #4572: Legend for deck.gl scatterplot
URL: https://github.com/apache/incubator-superset/pull/4572#discussion_r173347009
 
 

 ##########
 File path: superset/assets/visualizations/Legend.jsx
 ##########
 @@ -0,0 +1,42 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+
+import './Legend.css';
+
+const propTypes = {
+  categories: PropTypes.object,
+  toggleCategory: PropTypes.func,
+};
+
+const defaultProps = {
+  categories: {},
+  toggleCategory: () => {},
+};
+
+export default class Legend extends React.PureComponent {
 
 Review comment:
   My idea was to use this as a legend for all visualization types that don't have a native one (like nvd3 has). Right now this component takes only a list of categories and is not specific to maps.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services