You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/07/20 22:54:16 UTC
[GitHub] spark pull request #14290: [SPARK-16657] [SQL] Replace children by innerChil...
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/14290
[SPARK-16657] [SQL] Replace children by innerChildren in InsertIntoHadoopFsRelationCommand and CreateHiveTableAsSelectCommand
#### What changes were proposed in this pull request?
The query in `InsertIntoHadoopFsRelationCommand` and `CreateHiveTableAsSelectCommand` should be treated as inner children, like what we did for the other similar nodes: `CreateDataSourceTableAsSelectCommand`, `innerChildren`, and `InsertIntoDataSourceCommand`.
The explain will be improved.
**Before:**
```
ExecutedCommand
: +- CreateHiveTableAsSelectCommand [Database:default}, TableName: tab1, InsertIntoHiveTable]
: +- Project [1 AS 1#13, 3 AS 3#14]
: +- OneRowRelation$
```
**After:**
```
ExecutedCommand
: +- CreateHiveTableAsSelectCommand [Database:default}, TableName: tab1, InsertIntoHiveTable]
: : +- Project [1 AS 1#13, 3 AS 3#14]
: : +- OneRowRelation$
```
#### How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark innerChildren
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14290.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14290
----
commit e0605cd7f03d3fca2e88982c95229e87bb1bce00
Author: gatorsmile <ga...@gmail.com>
Date: 2016-07-20T22:44:37Z
children->innerchildren
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14290: [SPARK-16657] [SQL] Replace children by innerChildren in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14290
**[Test build #62638 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62638/consoleFull)** for PR 14290 at commit [`e0605cd`](https://github.com/apache/spark/commit/e0605cd7f03d3fca2e88982c95229e87bb1bce00).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14290: [SPARK-16657] [SQL] Replace children by innerChildren in...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/14290
The analyzer resolution requires them as children. Although this is inconsistent with the other similar nodes, we still can tolerate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14290: [SPARK-16657] [SQL] Replace children by innerChildren in...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14290
**[Test build #62638 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62638/consoleFull)** for PR 14290 at commit [`e0605cd`](https://github.com/apache/spark/commit/e0605cd7f03d3fca2e88982c95229e87bb1bce00).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14290: [SPARK-16657] [SQL] Replace children by innerChildren in...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14290
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62638/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14290: [SPARK-16657] [SQL] Replace children by innerChil...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile closed the pull request at:
https://github.com/apache/spark/pull/14290
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14290: [SPARK-16657] [SQL] Replace children by innerChildren in...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14290
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org