You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Grant Ingersoll (JIRA)" <ji...@apache.org> on 2007/09/18 20:09:44 UTC

[jira] Created: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
------------------------------------------------------------------------------

                 Key: SOLR-359
                 URL: https://issues.apache.org/jira/browse/SOLR-359
             Project: Solr
          Issue Type: Improvement
          Components: clients - java
            Reporter: Grant Ingersoll
            Assignee: Grant Ingersoll


The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Work started: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on SOLR-359 started by Grant Ingersoll.

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-359:
---------------------------------

    Attachment: SOLR-359.patch

First draft of a patch:

Added FieldFlag.java to common package to share field flag information between the LukeReqHandler and the LukeResponse

Added to the LukeResponse to extract the flags information for each field and make it available in the Response.

Also exposed the indexInfo NamedList through a getter, since there are still other pieces of info that are not exposed, most notably the detailed information on each of the FieldTypes.  

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>         Attachments: SOLR-359.patch
>
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529506 ] 

Grant Ingersoll commented on SOLR-359:
--------------------------------------

I am working on extending the LukeRequestHandler (LRH) and the LukeResponse to give more info about the FieldTypes.  Right now, the LRH returns the name of the FieldType, but does not return the class name.  Also, I would like to return back more structured access to the FieldType information by extracting it from the IndexInfo in the same way the FieldInfo does now.

Currently,  I am mirroring what is done for the FieldInfo to add FieldTypeInfo. 

One question, though, LRH currently writes out the instance of the Analyzer (around line 371 of LRH), would it be better to just return the class name?  Or do people actually need the value of Analyzer.toString()

Also, do I need to worry about back-compatibility of the message?  That is, if I add in the class name of the FieldType instance (i.e. solr.IntField, etc.) does that break the compatibility of the message?

I will post a new patch shortly which has more access to the FieldType info.

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-359.patch
>
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-359:
---------------------------------

    Attachment: SOLR-359-v2.patch

This patch builds on the last one to provide map backed access to FieldType metadata in a similar vein to the current FieldInfo.  It adds the className of the FieldType into the LukeRequestHandler types NamedList.

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-359-v2.patch, SOLR-359.patch
>
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher resolved SOLR-359.
-------------------------------

    Resolution: Fixed

Patch applied, thanks!   

Luke keeps getting handier and handier.

I also agree that the analyzer output is useless, especially with the className attribute now.

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-359-v2.patch, SOLR-359.patch
>
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-359) LukeResponse.FieldInfo should expose the selected flags info and the indexInfo

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-359:
---------------------------------

    Priority: Minor  (was: Major)

Not major, wish the default for JIRA was not major

> LukeResponse.FieldInfo should expose the selected flags info and the indexInfo
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-359
>                 URL: https://issues.apache.org/jira/browse/SOLR-359
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>            Reporter: Grant Ingersoll
>            Assignee: Grant Ingersoll
>            Priority: Minor
>         Attachments: SOLR-359.patch
>
>
> The LukeResponse has access, when reading in the NamedList to more information that is not currently being shared, like the "flags" for each FieldInfo and/or the indexInfo object so that more info about the fields may be used by the client.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.