You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/12/11 01:26:59 UTC
Re: Review Request 16158: Added min/max functions to stout which take two
Options.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16158/
-----------------------------------------------------------
(Updated Dec. 11, 2013, 12:26 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
Changes
-------
BenM's comments. Added max as well.
Summary (updated)
-----------------
Added min/max functions to stout which take two Options.
Repository: mesos-git
Description (updated)
-------
See summary. It will be useful when you wanna keep track of the global min (or max). For example:
Option<int> lowest;
foreach (int value, values) {
lowest = min(lowest, value);
}
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am f9d1aed
3rdparty/libprocess/3rdparty/stout/Makefile.am 3e22851
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 42b75a5
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/16158/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 16158: Added min/max functions to stout which take two
Options.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16158/#review30158
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 11, 2013, 12:26 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16158/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 12:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary. It will be useful when you wanna keep track of the global min (or max). For example:
>
> Option<int> lowest;
>
> foreach (int value, values) {
> lowest = min(lowest, value);
> }
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am f9d1aed
> 3rdparty/libprocess/3rdparty/stout/Makefile.am 3e22851
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 42b75a5
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16158/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>