You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "klsince (via GitHub)" <gi...@apache.org> on 2023/02/02 17:59:45 UTC
[GitHub] [pinot] klsince opened a new pull request, #10223: refine a few logs for easier debugging
klsince opened a new pull request, #10223:
URL: https://github.com/apache/pinot/pull/10223
refine a few logs for easier debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] klsince commented on a diff in pull request #10223: refine a few logs for easier debugging
Posted by "klsince (via GitHub)" <gi...@apache.org>.
klsince commented on code in PR #10223:
URL: https://github.com/apache/pinot/pull/10223#discussion_r1094889916
##########
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java:
##########
@@ -303,8 +303,8 @@ private static boolean startPinotService(Object role, Callable<String> serviceSt
LOGGER.info("Starting a Pinot [{}] at {}s since launch", role, startOffsetSeconds());
String instanceId = serviceStarter.call();
LOGGER.info("Started Pinot [{}] instance [{}] at {}s since launch", role, instanceId, startOffsetSeconds());
- } catch (Exception e) {
- LOGGER.error(String.format("Failed to start a Pinot [%s] at %s since launch", role, startOffsetSeconds()), e);
+ } catch (Throwable t) {
Review Comment:
e.g. NoClassDefFoundError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10223: refine a few logs for easier debugging
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10223:
URL: https://github.com/apache/pinot/pull/10223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org