You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2010/04/25 21:25:49 UTC
[jira] Created: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
unchecked exceptions thrown in IPC Connection orphan clients
------------------------------------------------------------
Key: HADOOP-6723
URL: https://issues.apache.org/jira/browse/HADOOP-6723
Project: Hadoop Common
Issue Type: Bug
Components: ipc
Affects Versions: 0.20.2
Reporter: Todd Lipcon
Assignee: Todd Lipcon
Priority: Critical
Fix For: 0.21.0, 0.22.0
If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861868#action_12861868 ]
Tom White commented on HADOOP-6723:
-----------------------------------
+1
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861085#action_12861085 ]
Todd Lipcon commented on HADOOP-6723:
-------------------------------------
Hudson didn't post.
http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/480/
[exec] +1 overall. Here are the results of testing the latest attachment
[exec] http://issues.apache.org/jira/secure/attachment/12442802/hadoop-6723.txt
[exec] against trunk revision 937881.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
[exec] +1 core tests. The patch passed core unit tests.
[exec]
[exec] +1 contrib tests. The patch passed contrib unit tests.
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6723:
--------------------------------
Attachment: hadoop-6723-20-1.patch
Patch for 20 attached.
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723-20-1.patch, hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HADOOP-6723:
------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Fix Version/s: (was: 0.22.0)
Resolution: Fixed
I've just committed this. Thanks Todd!
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12871323#action_12871323 ]
Hudson commented on HADOOP-6723:
--------------------------------
Integrated in Hadoop-Common-trunk #346 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/346/])
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6723:
--------------------------------
Status: Patch Available (was: Open)
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Jeff Hammerbacher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863725#action_12863725 ]
Jeff Hammerbacher commented on HADOOP-6723:
-------------------------------------------
Any reason this hasn't been committed yet?
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6723:
--------------------------------
Attachment: (was: hadoop-6723-20-1.patch)
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723-20-1.patch, hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12870772#action_12870772 ]
Hudson commented on HADOOP-6723:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #264 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/264/])
HADOOP-6723. Unchecked exceptions thrown in IPC Connection should not orphan clients. Contributed by Todd Lipcon.
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-6723:
--------------------------------
Attachment: hadoop-6723.txt
Patch simply catches the exception and closes down the connection. The included test case times out without this patch, since the call waits forever.
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6723) unchecked exceptions thrown in IPC
Connection orphan clients
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-6723:
--------------------------------
Attachment: hadoop-6723-20-1.patch
Patch for 20 attached.
> unchecked exceptions thrown in IPC Connection orphan clients
> ------------------------------------------------------------
>
> Key: HADOOP-6723
> URL: https://issues.apache.org/jira/browse/HADOOP-6723
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc
> Affects Versions: 0.20.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: hadoop-6723-20-1.patch, hadoop-6723.txt
>
>
> If the server sends back some malformed data, for example, receiveResponse() can end up with an incorrect call ID. Then, when it tries to find it in the calls map, it will end up with null and throw NPE in receiveResponse. This isn't caught anywhere, so the original IPC client ends up hanging forever instead of catching an exception. Another example is if the writable implementation itself throws an unchecked exception or OOME.
> We should catch Throwable in Connection.run() and shut down the connection if we catch one.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.