[GitHub] markusthoemmes commented on issue #3567: Activation result integration with log store SPI

[GitBox <gi...@apache.org>]

markusthoemmes commented on issue #3567: Activation result integration with log store SPI
URL: https://github.com/apache/incubator-openwhisk/pull/3567#issuecomment-383811117
 
 
   I'm a bit hesitant to make this part of the LogStore SPI. It's about storing **logs** after all. I know we've overloaded this in the Invoker as well, as we pass the activation itself in there as well.
   
   This will become more apparent when we want to move the activations from the controller there as well. The controller doesn't log so a LogStore SPI seems not fitting there.
   
   Have you thought about dividing this in an ActivationStore SPI and a LogStore SPI? Or do we think that both backends will eventually always be the same?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services