You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/21 20:27:11 UTC
[GitHub] [airflow] Kawaamai opened a new pull request #7234: [AIRFLOW-6493]
Add SSL configuration to Redis hook connections
Kawaamai opened a new pull request #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234
`redis-py` has support for TLS/SSL connections. This change allows SSL parameters for Redis to be configurable through the connection's extras field.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 85.06% -0.28%
==========================================
Files 791 791
Lines 40124 40128 +4
==========================================
- Hits 34242 34135 -107
- Misses 5882 5993 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.56% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...4664448](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `0.9%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 84.43% -0.91%
==========================================
Files 791 791
Lines 40124 40137 +13
==========================================
- Hits 34242 33890 -352
- Misses 5882 6247 +365
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...65247f7](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 85.06% -0.28%
==========================================
Files 791 791
Lines 40124 40128 +4
==========================================
- Hits 34242 34135 -107
- Misses 5882 5993 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.56% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...4664448](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-578048851
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin merged pull request #7234: [AIRFLOW-6493]
Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `1.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 84.18% -1.16%
==========================================
Files 791 791
Lines 40124 40137 +13
==========================================
- Hits 34242 33790 -452
- Misses 5882 6347 +465
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...65247f7](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7234: [AIRFLOW-6493] Add
SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `0.27%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 85.06% -0.28%
==========================================
Files 791 791
Lines 40124 40128 +4
==========================================
- Hits 34242 34135 -107
- Misses 5882 5993 +111
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `76.47% <0%> (-21.18%)` | :arrow_down: |
| [airflow/operators/bash.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvYmFzaC5weQ==) | `90.56% <0%> (ø)` | :arrow_up: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `91.88% <0%> (+0.28%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...4664448](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 84.62% -0.72%
==========================================
Files 791 791
Lines 40124 40137 +13
==========================================
- Hits 34242 33966 -276
- Misses 5882 6171 +289
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0%> (-46.67%)` | :arrow_down: |
| [airflow/executors/celery\_executor.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvY2VsZXJ5X2V4ZWN1dG9yLnB5) | `49.65% <0%> (-38.78%)` | :arrow_down: |
| [airflow/providers/redis/sensors/redis\_key.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvc2Vuc29ycy9yZWRpc19rZXkucHk=) | `61.53% <0%> (-38.47%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...65247f7](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576865792
Congratulations on your first Pull Request and welcome to the Apache Airflow community!
If you have any issues or are unsure about any anything please check our
Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits](
https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks)
will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory).
Adding a new operator? Check this short [guide](https://github
.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows
how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing
locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from
Committers.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `1.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 84.18% -1.16%
==========================================
Files 791 791
Lines 40124 40137 +13
==========================================
- Hits 34242 33790 -452
- Misses 5882 6347 +465
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...65247f7](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7234:
[AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#issuecomment-576896420
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=h1) Report
> Merging [#7234](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/059eda05f82fefce4410f44f761f945a27d83daf?src=pr&el=desc) will **decrease** coverage by `1.15%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7234 +/- ##
==========================================
- Coverage 85.34% 84.18% -1.16%
==========================================
Files 791 791
Lines 40124 40137 +13
==========================================
- Hits 34242 33790 -452
- Misses 5882 6347 +465
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/redis/hooks/redis.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvaG9va3MvcmVkaXMucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/operators/generic\_transfer.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvZ2VuZXJpY190cmFuc2Zlci5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0%> (-72.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/api/auth/backend/kerberos\_auth.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9hcGkvYXV0aC9iYWNrZW5kL2tlcmJlcm9zX2F1dGgucHk=) | `28.16% <0%> (-54.93%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50% <0%> (-50%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
| ... and [23 more](https://codecov.io/gh/apache/airflow/pull/7234/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=footer). Last update [059eda0...65247f7](https://codecov.io/gh/apache/airflow/pull/7234?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on a change in pull request
#7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7234: [AIRFLOW-6493] Add SSL configuration to Redis hook connections
URL: https://github.com/apache/airflow/pull/7234#discussion_r370297981
##########
File path: airflow/providers/redis/hooks/redis.py
##########
@@ -54,6 +58,13 @@ def get_conn(self):
self.password = None if str(conn.password).lower() in ['none', 'false', ''] else conn.password
self.db = conn.extra_dejson.get('db', None)
+ # check for ssl parameters in conn.extra
+ ssl_args = {}
+ for arg_name, arg_val in conn.extra_dejson.items():
+ if arg_name in ["ssl", "ssl_cert_reqs", "ssl_ca_certs", "ssl_keyfile", "ssl_cert_file",
+ "ssl_check_hostname"]:
+ ssl_args[arg_name] = arg_val
Review comment:
```python
ssl_args_names = ["ssl", "ssl_cert_reqs", "ssl_ca_certs", "ssl_keyfile", "ssl_cert_file", "ssl_check_hostname"]
ssl_args = {n: v for n, v conn.extra_dejson.items() if n in ssl_args_names}
```
What do you think about simplifying this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services