You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2022/10/09 02:51:04 UTC

[GitHub] [thrift] fishy commented on a diff in pull request #2697: THRIFT-5649: add github action for go

fishy commented on code in PR #2697:
URL: https://github.com/apache/thrift/pull/2697#discussion_r990723205


##########
.github/workflows/build.yml:
##########
@@ -51,6 +51,80 @@ jobs:
           path: compiler/cpp/thrift
           retention-days: 3
 
+  lib-go:
+    needs: compiler
+    runs-on: ubuntu-20.04
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: actions/setup-go@v3
+        with:
+          go-version: '>=1.17.0'

Review Comment:
   the current supported go versions are 1.18.x and 1.19.x: https://github.com/apache/thrift/blob/master/LANGUAGES.md, not 1.17.x.
   
   but looks like it actually picks the latest version (1.19.1) from the logs, so I think we probably actually need two actions, one for `lib-go-1.18` with `<1.19.0` and one for `lib-go-1.19` with `>=1.19.0`, or something like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org