You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/12/14 06:06:02 UTC
[kudu-CR] [java clien] update propagate TS for AUTO FLUSH SYNC flush mode
Hao Hao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8837
Change subject: [java clien] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java clien] update propagate TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagate timestamp for all write modes except
AUTO_FLUSH_SYNC for java cliemt. This patch adds it and updates
TestHybridTime to ensure propagate timestamp is updated for all flush
modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
3 files changed, 28 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/1
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 4:
(3 comments)
Thanks a lot for the review!
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@336
PS4, Line 336: received
> nit: the client received
Done
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@339
PS4, Line 339: is not empty
> s/is not empty/"has been set" or somesuch
Done
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@341
PS4, Line 341: synchronized
> not public? why
Was not sure if we want to introduce this method as public API, I do not see much benefits since clients can use other API to achieve the same effort. Though I also do not see any harms to do so. So I am open to both ways.
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 23:51:14 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@9
PS3, Line 9: propagate
nit: propagated
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: cliemt
typo
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: for
nit: the java
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: it
nit: "this" or "timestamp propagation for this mode"
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@11
PS3, Line 11: propagate
nit:propagated
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS3, Line 534: propagated the
the propagated
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS3, Line 92: single
single client?
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@141
PS3, Line 141: client.getLastPropagatedTimestamp()
do we have a client.hasLastPropagatedTimestamp() that does this internally? if not could we add it?
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 22:11:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 08 Jan 2018 19:03:35 +0000
Gerrit-HasComments: No
[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8837
to look at the new patch set (#3).
Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagate timestamp for all write modes except
AUTO_FLUSH_SYNC for java cliemt. This patch adds it and updates
TestHybridTime to ensure propagate timestamp is updated for all flush
modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
3 files changed, 28 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/3
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 3
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@341
PS4, Line 341: public synch
> Was not sure if we want to introduce this method as public API, I do not se
Discussed with David offline. I am going to make this method public API since it looks more nature as getLastPropagatedTimestamp() is also public.
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 06 Jan 2018 00:25:55 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java clien] update propagate TS for AUTO FLUSH SYNC flush mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java clien] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 2:
(2 comments)
does the changes made to test make it fail prior to the fix? can you mention that in the commit message?
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS2, Line 534: // Add a callback to update propagated timestamp returned from server.
nit: missing "the"
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS2, Line 92: single operations
operation?
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 02 Jan 2018 22:34:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8837
to look at the new patch set (#5).
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagated timestamp for all write modes
except AUTO_FLUSH_SYNC for the java client. This patch adds timestamp
propagation for this mode and updates TestHybridTime to ensure
propagated timestamp is updated for all flush modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
4 files changed, 39 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/5
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 5
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8837
to look at the new patch set (#4).
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagated timestamp for all write modes
except AUTO_FLUSH_SYNC for the java client. This patch adds timestamp
propagation for this mode and updates TestHybridTime to ensure
propagated timestamp is updated for all flush modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
4 files changed, 38 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/4
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@9
PS3, Line 9: propagate
> nit: propagated
Done
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: H_S
> nit: the java
Done
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: r the
> typo
Done
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@10
PS3, Line 10: pa
> nit: "this" or "timestamp propagation for this mode"
Done
http://gerrit.cloudera.org:8080/#/c/8837/3//COMMIT_MSG@11
PS3, Line 11: and upda
> nit:propagated
Done
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS3, Line 534: the propagated
> the propagated
Oops, my bad. Update.
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS3, Line 92: AUTO_F
> single client?
This comment is originally from L97. My understanding of why it was putting 'single operation' here is to refer flush mode AUTO_FLUSH_SYNC which return right after being flushed to the server for each write operation, compares to MANUAL_FLUSH mode which batching multiple writes. Maybe I should update the comment to specify the flush mode instead. I will do that.
http://gerrit.cloudera.org:8080/#/c/8837/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@141
PS3, Line 141: client.hasLastPropagatedTimestamp()
> do we have a client.hasLastPropagatedTimestamp() that does this internally?
Done
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 23:19:49 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagated timestamp for all write modes
except AUTO_FLUSH_SYNC for the java client. This patch adds timestamp
propagation for this mode and updates TestHybridTime to ensure
propagated timestamp is updated for all flush modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Reviewed-on: http://gerrit.cloudera.org:8080/8837
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
5 files changed, 48 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
David Ribeiro Alves: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 7
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] update propagate TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagate TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java:
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@534
PS2, Line 534: // Add a callback to update propagated timestamp returned from server.
> nit: missing "the"
Done
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java:
http://gerrit.cloudera.org:8080/#/c/8837/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java@92
PS2, Line 92: single operations
> operation?
Done
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 2
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 21:39:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8837 )
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
Patch Set 4:
(3 comments)
thanks for addressing my nits, have a couple more and should be gtg
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@336
PS4, Line 336: received
nit: the client received
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@339
PS4, Line 339: is not empty
s/is not empty/"has been set" or somesuch
http://gerrit.cloudera.org:8080/#/c/8837/4/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@341
PS4, Line 341: synchronized
not public? why
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 4
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 05 Jan 2018 23:22:57 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java client] update propagated TS for AUTO FLUSH SYNC flush mode
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8837
to look at the new patch set (#6).
Change subject: [java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
......................................................................
[java client] update propagated TS for AUTO_FLUSH_SYNC flush mode
Commit be6b81057 updated propagated timestamp for all write modes
except AUTO_FLUSH_SYNC for the java client. This patch adds timestamp
propagation for this mode and updates TestHybridTime to ensure
propagated timestamp is updated for all flush modes.
Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHybridTime.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScannerMultiTablet.java
5 files changed, 48 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/8837/6
--
To view, visit http://gerrit.cloudera.org:8080/8837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf0ca58b10842cb15ed5db7bcd4694c4d8cc3a89
Gerrit-Change-Number: 8837
Gerrit-PatchSet: 6
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins