You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "codecov[bot] (via GitHub)" <gi...@apache.org> on 2023/06/20 12:07:01 UTC
[GitHub] [superset] codecov[bot] commented on pull request #24429: fix: Viz migration adjustments - 2
codecov[bot] commented on PR #24429:
URL: https://github.com/apache/superset/pull/24429#issuecomment-1598650174
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24429](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6a471a) into [master](https://app.codecov.io/gh/apache/superset/commit/c69634df279054de0eb145bdcc796cb8fdd26dd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c69634d) will **decrease** coverage by `10.90%`.
> The diff coverage is `69.80%`.
> :exclamation: Current head a6a471a differs from pull request most recent head 6aaa108. Consider uploading reports for the commit 6aaa108 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24429 +/- ##
===========================================
- Coverage 68.90% 58.01% -10.90%
===========================================
Files 1903 1901 -2
Lines 74070 73974 -96
Branches 8110 8119 +9
===========================================
- Hits 51041 42914 -8127
- Misses 20917 28949 +8032
+ Partials 2112 2111 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| postgres | `?` | |
| presto | `53.82% <67.62%> (+0.02%)` | :arrow_up: |
| python | `60.56% <68.94%> (-22.66%)` | :arrow_down: |
| unit | `54.60% <66.51%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ackages/superset-ui-core/src/utils/featureFlags.ts](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdXRpbHMvZmVhdHVyZUZsYWdzLnRz) | `100.00% <ø> (ø)` | |
| [...acy-preset-chart-deckgl/src/components/Tooltip.tsx](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvY29tcG9uZW50cy9Ub29sdGlwLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...preset-chart-deckgl/src/layers/Geojson/Geojson.jsx](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL0dlb2pzb24vR2VvanNvbi5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...et-chart-deckgl/src/layers/Geojson/controlPanel.ts](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LWRlY2tnbC9zcmMvbGF5ZXJzL0dlb2pzb24vY29udHJvbFBhbmVsLnRz) | `50.00% <ø> (ø)` | |
| [...lugins/plugin-chart-table/src/utils/formatValue.ts](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtdGFibGUvc3JjL3V0aWxzL2Zvcm1hdFZhbHVlLnRz) | `66.66% <0.00%> (-3.93%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/fixtures.ts](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9maXh0dXJlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `40.93% <0.00%> (-0.25%)` | :arrow_down: |
| [...c/components/Chart/DrillDetail/DrillDetailPane.tsx](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hhcnQvRHJpbGxEZXRhaWwvRHJpbGxEZXRhaWxQYW5lLnRzeA==) | `75.32% <ø> (ø)` | |
| [...-frontend/src/components/TableCollection/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVDb2xsZWN0aW9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...end/src/dashboard/components/SliceHeader/index.tsx](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyL2luZGV4LnRzeA==) | `90.56% <ø> (ø)` | |
| ... and [154 more](https://app.codecov.io/gh/apache/superset/pull/24429?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [179 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24429/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org