You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/04 23:21:28 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #9116: Fix unload namespaces bundle hangs.

codelipenghui commented on a change in pull request #9116:
URL: https://github.com/apache/pulsar/pull/9116#discussion_r551626342



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1597,12 +1597,12 @@ public void checkTopicNsOwnership(final String topic) throws BrokerServiceExcept
     }
 
     public void cleanUnloadedTopicFromCache(NamespaceBundle serviceUnit) {
-        topics.forEach((name, topicFuture) -> {
-            TopicName topicName = TopicName.get(name);
+        for (String topic : topics.keys()) {

Review comment:
       It returns a copy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org