You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lsergio (via GitHub)" <gi...@apache.org> on 2024/03/06 14:38:58 UTC
[PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
lsergio opened a new pull request, #5224:
URL: https://github.com/apache/camel-k/pull/5224
<!-- Description -->
closes #5218
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "lsergio (via GitHub)" <gi...@apache.org>.
lsergio commented on PR #5224:
URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983513027
@lburgazzoli @squakez I added a comment to the bug with the scenarios that I tested after the changes: https://github.com/apache/camel-k/issues/5223#issuecomment-1981524817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #5224:
URL: https://github.com/apache/camel-k/pull/5224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "lsergio (via GitHub)" <gi...@apache.org>.
lsergio commented on PR #5224:
URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1981040120
So far I have onlu changed datatypes; still need to check where the code is using 25 and not 25% as default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "lsergio (via GitHub)" <gi...@apache.org>.
lsergio commented on PR #5224:
URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1981323103
I see that in v2.2.0 the 25 default value is set at the crd (https://github.com/apache/camel-k/blob/v2.2.0/helm/camel-k/crds/crd-integration.yaml#L6755). It was supposed to mean 25% but it really means 25.
However, the main branch does not have such a value (https://github.com/apache/camel-k/blob/main/helm/camel-k/crds/crd-integration.yaml#L6755) an thus delegate the default values to Kubernetes.
So I think the wrong default value of 25 instead of 25% is no longer an issue and this PR would fix only the datatype in order to allow the users to inform percentage values on the trait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5224:
URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983468741
@lburgazzoli do you think this is breaking API compatibility by any chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(trait): changing data type for rollingUpdateMaxSurge and rollingU… [camel-k]
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #5224:
URL: https://github.com/apache/camel-k/pull/5224#issuecomment-1983530891
> @lburgazzoli @squakez I added a comment to the bug with the scenarios that I tested after the changes: [#5223 (comment)](https://github.com/apache/camel-k/issues/5223#issuecomment-1981524817)
Thanks I saw it. Checking with @lburgazzoli if he see some possible incompatibility I don't see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org