You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by GitBox <gi...@apache.org> on 2026/05/29 23:03:42 UTC
[GH] (grails-core/deps/spock-2.4): Workflow run "CI" is working again!
The GitHub Actions job "CI" on grails-core.git/deps/spock-2.4 has succeeded.
Run started by GitHub user jamesfredley (triggered by jamesfredley).
Head commit for run:
3e6dabc97cdff6b086b363a6eff1bd9c8ac0ce93 / James Fredley <ja...@users.noreply.github.com>
Fix Spock 2.4 test incompatibilities in views-gson and datamapping-core
Spock 2.4 tightened two behaviors that two existing tests relied on:
- JsonViewTemplateResolverSpec stubbed the final methods getRequest() and
getResponse() on a GrailsWebRequest mock. Spock 2.3 silently ignored
final-method stubs; Spock 2.4's byte-buddy mock maker fails fast with
InvalidSpecException. The stubs were dead (the test passes the request and
response to resolveView() explicitly), so they are removed.
- TransactionalTransformSpec reflectively invoked the @Rollback-transformed
Spock feature methods directly, outside Spock's runner. Spock 2.4 throws
IllegalStateException ("Cannot request current iteration") for closures
that reference data variables or contain conditions when there is no active
iteration. The direct call was never faithful to real Spock execution; the
GroovyShell compilation plus the transformed method-signature assertions
already cover the #9837 and #9646 regressions, so the direct-invocation
blocks are removed.
Assisted-by: claude-code:claude-opus-4-8
Report URL: https://github.com/apache/grails-core/actions/runs/26665323501
With regards,
GitHub Actions via GitBox