You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/16 06:58:06 UTC

[GitHub] [arrow-rs] viirya commented on a diff in pull request #1573: Use littleendian arrow files for `projection_should_work`

viirya commented on code in PR #1573:
URL: https://github.com/apache/arrow-rs/pull/1573#discussion_r851595441


##########
arrow/src/ipc/reader.rs:
##########
@@ -1108,15 +1108,13 @@ mod tests {
     }
 
     #[test]
-    // https://github.com/apache/arrow-rs/issues/1548
-    #[cfg(not(feature = "force_validate"))]
     fn projection_should_work() {
         // complementary to the previous test
         let testdata = crate::util::test_util::arrow_test_data();
         let paths = vec![
             "generated_interval",
             "generated_datetime",
-            // "generated_map", Err: Last offset 872415232 of Utf8 is larger than values length 52 (https://github.com/apache/arrow-rs/issues/859)

Review Comment:
   This is also due to bigendian offsets. So I uncomment it too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org