Re: [PR] Fix FileNotFoundException handling in segment download API [pinot]

["rsrkpatwari1234 (via GitHub)" <gi...@apache.org>]

rsrkpatwari1234 commented on code in PR #17523:
URL: https://github.com/apache/pinot/pull/17523#discussion_r3174287683


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/fetcher/HttpSegmentFetcher.java:
##########
@@ -106,20 +108,26 @@ public void fetchSegmentToLocal(URI downloadURI, File dest)
         return true;
       } catch (HttpErrorStatusException e) {
         int statusCode = e.getStatusCode();
-        if (statusCode == HttpStatus.SC_NOT_FOUND || statusCode >= 500) {
-          // Temporary exception
-          // 404 is treated as a temporary exception, as the downloadURI may be backed by multiple hosts,
-          // if singe host is down, can retry with another host.

Review Comment:
   Fixed the code to only fix handling for FileNotFound exception



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org