You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/02 09:46:15 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2165: Deprecated WinXP and Server2003 methods
emmenlau opened a new pull request #2165:
URL: https://github.com/apache/thrift/pull/2165
This PR adds a very minor change: it deprecates handling of WinXP and Windows Server 2003 in `lib/cpp/src/thrift/windows/WinFcntl.{h,cpp}`. This simplifies code maintenance. I'm under the impression that support for WinXP should be dropped now.
Does this require an explicit mention in a change log? I would assume that WinXP and Server 2003 are not officially supported since a while now?
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-685305102
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653386681
BTW what's the state of the matter? You know what I mean ... ;-) Can we help somehow? => email
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653385187
+1 LGTM but needs a rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-689565242
I've rebased on latest master, and added the change to CHANGES.md. Does it look good like this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-691939033
Thanks @Jens-G !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653385821
> I would assume that WinXP and Server 2003 are not officially supported since a while now?
There is no explicit policy in place but folllowing the support cycles given by Microsoft has proven to be a good working model. So I'd poropse we do the same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653385821
> I would assume that WinXP and Server 2003 are not officially supported since a while now?
There is no explicit policy in place but folllowing the support cycles given by Microsoft has proven to be a good working model. So I'd poropse we do the same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-689563368
This issue is no longer stale. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-645663731
> Does this require an explicit mention in a change log?
> I would assume that WinXP and Server 2003 are not officially supported since a while now?
I'd still mention it. You're right but technically it is still a breaking change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2165:
URL: https://github.com/apache/thrift/pull/2165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2165:
URL: https://github.com/apache/thrift/pull/2165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2165:
URL: https://github.com/apache/thrift/pull/2165
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G edited a comment on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653385821
> I would assume that WinXP and Server 2003 are not officially supported since a while now?
There is no explicit policy in place but folllowing the support cycles given by Microsoft has proven to be a good working model. So I'd poropse we do the same here. Which also implies that Win7 is dead, except that it still is used in the industry, so dropping Win7 support (if we have any specifics at all) at the end of 2020 seems more reasonable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-653386681
BTW what's the state of the matter? You know what I mean ... ;-) Can we help somehow?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2165: Deprecated WinXP and Server2003 methods
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2165:
URL: https://github.com/apache/thrift/pull/2165#issuecomment-689727723
Checked, the build errors in Travis are all unrelated. Ready for review and merge...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org