[GitHub] leventov commented on a change in pull request #6540: add close method in Cache interface

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #6540: add close method in Cache interface
URL: https://github.com/apache/incubator-druid/pull/6540#discussion_r238653079
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/cache/HybridCache.java
 ##########
 @@ -131,6 +134,15 @@ public void close(String namespace)
     level2.close(namespace);
   }
 
+  @Override
+  @LifecycleStop
+  public void close() throws IOException
+  {
+    try (Closeable closeable1 = level1; Closeable closeable2 = level2) {
 
 Review comment:
   Please create a PR or an issue

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org