[GitHub] wujimin commented on a change in pull request #755: [SCB-649] when port can't been listened, log warn and show more detail message

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #755: [SCB-649] when port can't been listened,log warn and show more detail message
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/755#discussion_r193600409
 
 

 ##########
 File path: transports/transport-rest/transport-rest-vertx/src/main/java/org/apache/servicecomb/transport/rest/vertx/VertxRestTransport.java
 ##########
 @@ -59,7 +59,7 @@ public boolean canInit() {
     }
 
     if (!NetUtils.canTcpListen(ep.getSocketAddress().getAddress(), ep.getPort())) {
-      log.info("can not listen {}, skip {}.", ep.getSocketAddress(), this.getClass().getName());
+      log.warn("can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}.", ep.getSocketAddress(), this.getClass().getName());
 
 Review comment:
   so strange......
   canTcpListen is to detect, if this transport can init
   when customers deployed vertx and servlet rest transport, we must detect which one will be used
   only both of them refused to init is a problem.
   we have already print that......

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services