You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/30 17:40:54 UTC

[GitHub] [incubator-tvm] kazum opened a new pull request #5489: [Rust] Fixes for wasm32 target

kazum opened a new pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489


   This PR fixes warnings and errors when targeting wasm32.
   - Update the BackendPackedCFunc signature which was changed in #4637.
   - Use derive_default() for bindgen to handle the generated padding field.
   - Add workaround for nom::length_data, which doesn't allow u64 on 32-bit architecture.
   - Terminate the thread safely instead of panic when crossbeam-channel is closed.
   - Remove unused import warnings.
   
   @jroesch @nhynes @ehsanmok @tqchen Please help to review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch commented on pull request #5489: [Rust] Fixes for wasm32 target

Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489#issuecomment-622091138


   Could you actually add some kind of test which checks that we compile correctly for WASM target? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] ehsanmok commented on pull request #5489: [Rust] Fixes for wasm32 target

Posted by GitBox <gi...@apache.org>.
ehsanmok commented on pull request #5489:
URL: https://github.com/apache/incubator-tvm/pull/5489#issuecomment-622074069


   Thanks @kazum! LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org