You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/23 04:52:19 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #35617: [SPARK-38297][PYTHON] Explicitly cast the return value at DataFrame.to_numpy in POS
HyukjinKwon opened a new pull request #35617:
URL: https://github.com/apache/spark/pull/35617
### What changes were proposed in this pull request?
MyPy build currently fails as below:
```
starting mypy annotations test...
annotations failed mypy checks:
python/pyspark/pandas/generic.py:585: error: Incompatible return value type (got "Union[ndarray[Any, Any], ExtensionArray]", expected "ndarray[Any, Any]") [return-value]
Found 1 error in 1 file (checked 324 source files)
1
```
https://github.com/apache/spark/runs/5298261168?check_suite_focus=true
I tried to reproduce in my local by matching NumPy and MyPy versions but failed. So I decided to work around the problem first by explicitly casting to make MyPy happy.
### Why are the changes needed?
To make the build pass.
### Does this PR introduce _any_ user-facing change?
No, dev-only.
### How was this patch tested?
CI in this PR should verify if it's fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35617: [SPARK-38297][PYTHON] Explicitly cast the return value at DataFrame.to_numpy in POS
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35617:
URL: https://github.com/apache/spark/pull/35617#issuecomment-1048454522
Linter passed:
```
...
black checks passed.
starting flake8 test...
flake8 checks passed.
starting mypy annotations test...
annotations passed mypy checks.
starting mypy examples test...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35617: [SPARK-38297][PYTHON] Explicitly cast the return value at DataFrame.to_numpy in POS
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35617:
URL: https://github.com/apache/spark/pull/35617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #35617: [SPARK-38297][PYTHON] Explicitly cast the return value at DataFrame.to_numpy in POS
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #35617:
URL: https://github.com/apache/spark/pull/35617#issuecomment-1048454777
Merged to master and branch-3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35617: [SPARK-38297][PYTHON] Explicitly cast the return value at DataFrame.to_numpy in POS
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35617:
URL: https://github.com/apache/spark/pull/35617#issuecomment-1048454777
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org