You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/04/19 11:07:10 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request, #6106: LICENSE: fix missing licenses and document the missing ones
jerpelea opened a new pull request, #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106
## Summary
fix missing licenses to LICENSE files
## Impact
LICENSE
## Testing
NONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a diff in pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106#discussion_r852968718
##########
boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h:
##########
@@ -1,3 +1,23 @@
+/***************************************************************************
+ * boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
unsigned char romfs_img[] = {
Review Comment:
we can ask that the license is added to the contribution when the file is regenerated
##########
boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h:
##########
@@ -1,3 +1,23 @@
+/***************************************************************************
+ * boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
unsigned char romfs_img[] = {
Review Comment:
we can ask that the license is added to the contribution after the file is regenerated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106#discussion_r853010125
##########
drivers/mtd/gd5f.c:
##########
@@ -1,9 +1,7 @@
/****************************************************************************
* drivers/mtd/gd5f.c
- * Driver for GigaDevice SPI nand flash.
Review Comment:
this one can change to apache, since fishsemi(xiaomi) already sign CLA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106#discussion_r852917161
##########
boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h:
##########
@@ -1,3 +1,23 @@
+/***************************************************************************
+ * boards/arm/sama5/sama5d4-ek/include/nsh_romfsimg.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ***************************************************************************/
+
unsigned char romfs_img[] = {
Review Comment:
as far as I know such files are autogenerated. I'm not sure if the proper steps to regenerate are run as a part of the build process. Probably not, but the licence information will be lost as soon as someone runs a script to generate a new content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a diff in pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
jerpelea commented on code in PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106#discussion_r853020357
##########
drivers/mtd/gd5f.c:
##########
@@ -1,9 +1,7 @@
/****************************************************************************
* drivers/mtd/gd5f.c
- * Driver for GigaDevice SPI nand flash.
Review Comment:
solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #6106: LICENSE: fix missing licenses and document the missing ones
Posted by GitBox <gi...@apache.org>.
jerpelea commented on PR #6106:
URL: https://github.com/apache/incubator-nuttx/pull/6106#issuecomment-1102589929
please ignore the remaining nxstyle errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org