You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/04/27 04:58:23 UTC
[isis] branch master updated: ISIS-2297: fixes flipped logic in prev. commit
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 06dd193531 ISIS-2297: fixes flipped logic in prev. commit
06dd193531 is described below
commit 06dd193531421dda7962734f53ba2909dbf2d285
Author: Andi Huber <ah...@apache.org>
AuthorDate: Wed Apr 27 06:58:18 2022 +0200
ISIS-2297: fixes flipped logic in prev. commit
---
.../main/java/org/apache/isis/commons/internal/primitives/_Doubles.java | 2 +-
.../main/java/org/apache/isis/commons/internal/primitives/_Floats.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
index 02ae21859f..5767fd6592 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Doubles.java
@@ -61,7 +61,7 @@ public class _Doubles {
public double convertToDouble(final @NonNull BigDecimal decimal) {
val doubleValue = decimal.doubleValue();
// overflow detection
- if(!Double.isInfinite(doubleValue)) {
+ if(!Double.isFinite(doubleValue)) {
throw new ArithmeticException("non finite BigDecimal to double conversion");
}
return doubleValue;
diff --git a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Floats.java b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Floats.java
index 432ff58257..2a24bea739 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Floats.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/primitives/_Floats.java
@@ -58,7 +58,7 @@ public class _Floats {
public float convertToFloat(final @NonNull BigDecimal decimal) {
val floatValue = decimal.floatValue();
// overflow detection
- if(!Float.isInfinite(floatValue)) {
+ if(!Float.isFinite(floatValue)) {
throw new ArithmeticException("non finite BigDecimal to float conversion");
}
return floatValue;