[GitHub] [nifi] andrewmlim commented on issue #3401: NIFI-6160 NIFI-6170 Apply config error handling convention

[GitBox <gi...@apache.org>]

andrewmlim commented on issue #3401: NIFI-6160 NIFI-6170 Apply config error handling convention
URL: https://github.com/apache/nifi/pull/3401#issuecomment-481780647
 
 
   @ijokarumawak Latest changes look good to me. I tested all the components listed (also Registry Client), but was not able to test the following:
   
   - ControllerService
   - Label
   
   Not sure what I can do in the UI to cause a Configuration Error for those two.
   
   I found one issue though, that I can file a separate Jira for.  When modifying the Concurrent Tasks on an Input/Output port by adding a very large integer, I get these two errors:
   
   - Cannot deserialize value of type `java.lang.Integer` from String "123123123123": Overflow: numeric value (123123123123) out of range of Integer (-2147483648 - 2147483647)
   - at [Source: (org.glassfish.jersey.message.internal.ReaderInterceptorExecutor$UnCloseableInputStream); line: 1, column: 231] (through reference chain: org.apache.nifi.web.api.entity.PortEntity["component"]->org.apache.nifi.web.api.dto.PortDTO["concurrentlySchedulableTaskCount"])
   
   If there is a limit, perhaps we can state that as an error message instead or make the errors more user friendly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services