You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2018/03/01 00:27:48 UTC
Re: Review Request 65839: Windows: Removed W* test-only macros in
`windows.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65839/#review198420
-----------------------------------------------------------
Changes LGTM but this needs to be split into three commits as you're touching stout, libprocess, and mesos. Do you have the Git hooks installed? They should have warned you.
- Andrew Schwartzmeyer
On Feb. 28, 2018, 10:09 a.m., Akash Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65839/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 10:09 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `windows.hpp` defined a few macros for the status value of `waitpid`
> that were either unused in the code base or were only used in gtest.
> These macros handled signal logic, so they were removed since they
> aren't used on Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/gtest.hpp dd4c9bdf7e6e0e45db347108fde3b41960974be6
> 3rdparty/stout/include/stout/gtest.hpp ce6e4de6a9f69ea121ff0ca6048316d678c8c857
> 3rdparty/stout/include/stout/windows.hpp b35e6b94ba6709254450be9429b6f48f2d276689
> src/checks/checker_process.cpp cf9ec053946e620eb36e92d647ab864c4e88d506
>
>
> Diff: https://reviews.apache.org/r/65839/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Akash Gupta
>
>