You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@polygene.apache.org by ni...@apache.org on 2015/06/25 10:13:53 UTC

[5/6] zest-qi4j git commit: Clarifying error message.

Clarifying error message.


Project: http://git-wip-us.apache.org/repos/asf/zest-qi4j/repo
Commit: http://git-wip-us.apache.org/repos/asf/zest-qi4j/commit/3a089bc7
Tree: http://git-wip-us.apache.org/repos/asf/zest-qi4j/tree/3a089bc7
Diff: http://git-wip-us.apache.org/repos/asf/zest-qi4j/diff/3a089bc7

Branch: refs/heads/develop
Commit: 3a089bc79a1ecc59b741388e9f78768d8ec12404
Parents: 8630305
Author: Niclas Hedhman <ni...@hedhman.org>
Authored: Thu Jun 25 15:53:04 2015 +0800
Committer: Niclas Hedhman <ni...@hedhman.org>
Committed: Thu Jun 25 15:53:04 2015 +0800

----------------------------------------------------------------------
 .../main/java/org/qi4j/runtime/injection/DependencyModel.java | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zest-qi4j/blob/3a089bc7/core/runtime/src/main/java/org/qi4j/runtime/injection/DependencyModel.java
----------------------------------------------------------------------
diff --git a/core/runtime/src/main/java/org/qi4j/runtime/injection/DependencyModel.java b/core/runtime/src/main/java/org/qi4j/runtime/injection/DependencyModel.java
index b01f799..a01d061 100644
--- a/core/runtime/src/main/java/org/qi4j/runtime/injection/DependencyModel.java
+++ b/core/runtime/src/main/java/org/qi4j/runtime/injection/DependencyModel.java
@@ -293,9 +293,14 @@ public final class DependencyModel
         }
         if( injectedValue == null && !optional )
         {
+            String simpleName = injectionAnnotation.annotationType().getSimpleName();
             String message = "[Module " + context.module().name() + "] Non-optional @" +
-                             injectionAnnotation.annotationType().getSimpleName() + " " + injectionType.toString() +
+                             simpleName + " " + injectionType.toString() +
                              " was null in " + injectedClass.getName();
+            if( simpleName.toLowerCase().contains( "service" ) )
+            {
+                message = message + ". Did you mean the @Service injection scope?";
+            }
             throw new ConstructionException( message );
         }
         return getInjectedValue( injectedValue );