You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2016/12/13 02:18:24 UTC
geode git commit: GEODE-2099: reduce scope of method and vars to
prevent spaghetti
Repository: geode
Updated Branches:
refs/heads/develop 079542b81 -> 70800f526
GEODE-2099: reduce scope of method and vars to prevent spaghetti
If you leave vars and methods public or protected, some day
someone is going to make another test call them (I've seen
it happen repeatedly) so please make them private.
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/70800f52
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/70800f52
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/70800f52
Branch: refs/heads/develop
Commit: 70800f5268382a3aca1b35b4c52ba5a70787e469
Parents: 079542b
Author: Kirk Lund <kl...@apache.org>
Authored: Mon Dec 12 18:17:24 2016 -0800
Committer: Kirk Lund <kl...@apache.org>
Committed: Mon Dec 12 18:17:24 2016 -0800
----------------------------------------------------------------------
.../geode/management/ConnectToLocatorSSLDUnitTest.java | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/70800f52/geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java b/geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
index 142ce17..457bd2e 100644
--- a/geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/ConnectToLocatorSSLDUnitTest.java
@@ -12,7 +12,6 @@
* or implied. See the License for the specific language governing permissions and limitations under
* the License.
*/
-
package org.apache.geode.management;
import static org.apache.geode.distributed.ConfigurationProperties.CLUSTER_SSL_ENABLED;
@@ -58,7 +57,6 @@ import java.io.OutputStream;
import java.util.Properties;
@Category(DistributedTest.class)
-
public class ConnectToLocatorSSLDUnitTest extends JUnit4DistributedTestCase {
@Rule
@@ -66,9 +64,9 @@ public class ConnectToLocatorSSLDUnitTest extends JUnit4DistributedTestCase {
@Rule
public LocatorServerStartupRule lsRule = new LocatorServerStartupRule();
- protected File jks = null;
- protected File securityPropsFile = null;
- protected Properties securityProps;
+ private File jks = null;
+ private File securityPropsFile = null;
+ private Properties securityProps;
@Before
public void before() throws Exception {
@@ -82,7 +80,7 @@ public class ConnectToLocatorSSLDUnitTest extends JUnit4DistributedTestCase {
securityPropsFile.delete();
}
- public void setUpLocatorAndConnect(Properties securityProps) throws Exception {
+ private void setUpLocatorAndConnect(Properties securityProps) throws Exception {
lsRule.startLocatorVM(0, securityProps);
// saving the securityProps to a file